test(data-pipeline): gate telemetry-only tests behind the telemetry feature#2204
Open
iunanua wants to merge 1 commit into
Open
test(data-pipeline): gate telemetry-only tests behind the telemetry feature#2204iunanua wants to merge 1 commit into
iunanua wants to merge 1 commit into
Conversation
Contributor
📚 Documentation Check Results📦
|
iunanua
force-pushed
the
igor/data-pipeline-no-default-features-tests
branch
from
8ba55ab to
fbfc3de
Compare
Contributor
Clippy Allow Annotation ReportComparing clippy allow annotations between branches:
Summary by Rule
Annotation Counts by File
Annotation Stats by Crate
About This ReportThis report tracks Clippy allow annotations for specific rules, showing how they've changed in this PR. Decreasing the number of these annotations generally improves code quality. |
Contributor
🔒 Cargo Deny Results📦
|
Contributor
🎉 All green!🧪 All tests passed 🎯 Code Coverage (details) 🔗 Commit SHA: 7c1d432 | Docs | Datadog PR Page | Give us feedback! |
Contributor
Artifact Size Benchmark Reportaarch64-alpine-linux-musl
aarch64-unknown-linux-gnu
libdatadog-x64-windows
libdatadog-x86-windows
x86_64-alpine-linux-musl
x86_64-unknown-linux-gnu
|
…eature Building the crate with `--no-default-features` (telemetry off) failed to compile because several tests and one example referenced `TelemetryConfig` and `TraceExporterBuilder::enable_telemetry`, both of which are gated behind the `telemetry` feature. Gate the telemetry-dependent test code and the `send-traces-with-stats` example accordingly, and silence an unused-variable warning in stats.rs for non-telemetry builds. Non-telemetry tests in `test_new`/`test_new_defaults` still run. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
iunanua
force-pushed
the
igor/data-pipeline-no-default-features-tests
branch
from
fbfc3de to
7c1d432
Compare
yannham
approved these changes
Jul 8, 2026
| metrics_endpoint.assert_calls(1); | ||
| } | ||
|
|
||
| #[cfg(feature = "telemetry")] |
Contributor
There was a problem hiding this comment.
Nit: 3 tests is in the gray zone, but would that make sense to gather those tests under a separate submodule and gate the submodule once and for all?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Building the crate with
--no-default-features(telemetry off) failed to compile because several tests and one example referencedTelemetryConfigandTraceExporterBuilder::enable_telemetry, both of which are gated behind thetelemetryfeature.Gate the telemetry-dependent test code and the
send-traces-with-statsexample accordingly, and silence an unused-variable warning in stats.rs for non-telemetry builds. Non-telemetry tests intest_new/test_new_defaultsstill run.