feat(sidecar): enable telemetry for stats#2175
Conversation
This stack of pull requests is managed by Graphite. Learn more about stacking. |
📚 Documentation Check Results📦
|
Clippy Allow Annotation ReportComparing clippy allow annotations between branches:
Summary by Rule
Annotation Counts by File
Annotation Stats by Crate
About This ReportThis report tracks Clippy allow annotations for specific rules, showing how they've changed in this PR. Decreasing the number of these annotations generally improves code quality. |
🔒 Cargo Deny Results📦
|
🎉 All green!🧪 All tests passed 🎯 Code Coverage (details) 🔗 Commit SHA: 2bb5ac0 | Docs | Datadog PR Page | Give us feedback! |
Artifact Size Benchmark Reportaarch64-alpine-linux-musl
aarch64-unknown-linux-gnu
libdatadog-x64-windows
libdatadog-x86-windows
x86_64-alpine-linux-musl
x86_64-unknown-linux-gnu
|
8fcfab9 to
94ad5e8
Compare
1f87e19 to
4c38bb8
Compare
4c38bb8 to
6413c5f
Compare
94ad5e8 to
5706ea9
Compare
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 4c38bb8b78
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
|
|
||
| let exporter = make_exporter( | ||
| &state, | ||
| state.endpoint.clone(), | ||
| flush_interval, |
There was a problem hiding this comment.
Refresh stats telemetry after client stops
This binds the flush loop to the telemetry worker that existed when the concentrator was created, but telemetry clients are removed on LifecycleAction::Stop while SHM concentrators are global and can remain active until an idle flush removes them. If another runtime for the same service/env continues using the existing concentrator after a Stop/start cycle, get_or_create_concentrator returns the old state and collapsed-span points keep going to the stopped worker instead of the newly created telemetry client; look up or refresh the worker when flushing rather than capturing it for the concentrator lifetime.
Useful? React with 👍 / 👎.
There was a problem hiding this comment.
@bwoebi I'm not very familiar with the sidecar lifecycle, can the telemetry client be stopped while the concentrator is reused ?
5706ea9 to
dae98bf
Compare
6413c5f to
9d522ee
Compare
9d522ee to
fd8554e
Compare
dae98bf to
3a03e6a
Compare
fd8554e to
ed6fab4
Compare
3a03e6a to
8745b80
Compare
ed6fab4 to
26b5e27
Compare
8745b80 to
06d7629
Compare
26b5e27 to
2bb5ac0
Compare

What does this PR do?
Enable span concentrator telemetry in sidecar.