Refactor git package#88
Open
anmarchenko wants to merge 3 commits into
Open
Conversation
This comment has been minimized.
This comment has been minimized.
Member
Author
E2E Test Report: SUCCESSTested by: Shepherd Agent (autonomous QA for Datadog Test Optimization) Test Environment
Results
Issues FoundNone. VerificationPlan-only ddtest runs do not emit a Test Visibility test session ID, so UI session verification was not applicable. Backend verification was performed directly through real EU API responses in debug logs, including settings, search_commits, skippable tests, suite durations, and packfile upload. Test Methodology
This E2E test was performed by Shepherd - autonomous QA agent for Datadog Test Optimization. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Unify Git metadata constants and helper functions under
internal/git, remove the old duplicated Git helper files, and add real-repository integration test coverage for Git-related Test Optimization flows.Why
This continues the Test Optimization refactor by removing duplicated Git plumbing from
internal/utilsandcivisibility/constants, making the Git integration surface easier to reason about and test. It also moves the disabled-test conversion into the Test Optimization client so planner code depends on client behavior rather than package-level helper leftovers.E2E testing
In a real Git repository with at least two commits and an origin remote, run
ddtest planfor a supported test project and verify that Test Optimization initialization reports repository URL, branch, commit SHA, commit author/committer metadata, and uploads missing Git objects when the backend reports only an older commit as known.