Repository navigation
Conversation
Contributor
There was a problem hiding this comment.
Copilot review overview
🟢 Approval recommended
The focused fix correctly addresses the reported boolean-defaulting bug and is adequately covered by tests.
Review effort: Balanced
Findings: None
What changed in this PR
Fixes Babel-based interaction tracking so explicit useAccessibilityLabel: false configuration is respected.
Changes:
- Uses nullish coalescing when applying the default.
- Adds initialization and action-naming precedence tests.
| File | Description |
|---|---|
packages/core/src/DdSdkReactNative.tsx |
Preserves explicit false configuration. |
packages/core/src/__tests__/DdSdkReactNative.test.tsx |
Tests configuration propagation and defaults. |
packages/core/src/rum/instrumentation/interactionTracking/__tests__/DdBabelInteractionTracking.test.ts |
Tests action naming with accessibility labels enabled and disabled. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
sbarrio
approved these changes
Oct 7, 2026
marco-saia-datadog
approved these changes
Oct 7, 2026
cdn34dd
deleted the
carlosnogueira/issue-1465/fix-babel-use-accessibility-label-config
branch
October 7, 2026 15:54
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes Babel interaction tracking ignoring
useAccessibilityLabel: falseby replacing||with??when applying the default configuration.Fixes #1465.
Review checklist (to be filled by reviewers)