Skip to content

Update ProGuard config of the sample app - #3972

Merged
0xnm merged 1 commit into
developfrom
nogorodnikov/update-proguard-config-091026
Oct 9, 2026
Merged

0xnm merged 1 commit into
developfrom
nogorodnikov/update-proguard-config-091026

Conversation

@0xnm

@0xnm 0xnm commented Oct 9, 2026

Copy link
Copy Markdown
Member

What does this PR do?

Without that Sample app is crashing when minification is enabled because of the Netty (it is using a lot of reflection).

Review checklist (to be filled by reviewers)

  • Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
  • Make sure you discussed the feature or bugfix with the maintaining team in an Issue
  • Make sure each commit and the PR mention the Issue number (cf the CONTRIBUTING doc)

@0xnm
0xnm requested review from a team as code owners October 9, 2026 13:58
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 9, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-09T14:00:45.309535Z f18e13d PR opened
🔒 Security Review ✅ Completed 2026-10-09T14:00:54.420156Z f18e13d PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@datadog-datadog-prod-us1-2 datadog-datadog-prod-us1-2 Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bits Code Review: PASS

More details

The Netty keep rule preserves classes and members needed for reflective access in the sample’s embedded server. Minified build and runtime behavior remain unverified.

Was this helpful? React 👍 or 👎

Open Bits AI session

🤖 Bits Code Review · Commit f18e13d

@datadog-datadog-prod-us1-2

datadog-datadog-prod-us1-2 Bot commented Oct 9, 2026 •

Copy link
Copy Markdown
Contributor

Tests

✅ All CI checks and tests passed. Datadog automation helped this PR pass.

🎉 All green!

🧪 All tests passed
❄️ No new flaky tests detected

🔄 Datadog retried 1 test - 1 passed on retry View in Datadog

🎯 Code Coverage (details)
• Patch Coverage: 100.00%
• Overall Coverage: 71.78% (-0.02%)

This comment will be updated automatically if new data arrives.
🔗 Commit SHA: f18e13d | Docs | View more details | Give us feedback!

@0xnm
0xnm merged commit 39ccdf8 into develop Oct 9, 2026
26 checks passed
@0xnm
0xnm deleted the nogorodnikov/update-proguard-config-091026 branch October 9, 2026 14:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants