Repository navigation
Update ProGuard config of the sample app - #3972
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
There was a problem hiding this comment.
More details
The Netty keep rule preserves classes and members needed for reflective access in the sample’s embedded server. Minified build and runtime behavior remain unverified.
🤖 Bits Code Review · Commit f18e13d
|
✅ All CI checks and tests passed. Datadog automation helped this PR pass. 🎉 All green!🧪 All tests passed 🔄 Datadog retried 1 test - 1 passed on retry 🎯 Code Coverage (details) 🔗 Commit SHA: f18e13d | Docs | View more details | Give us feedback! |
What does this PR do?
Without that Sample app is crashing when minification is enabled because of the Netty (it is using a lot of reflection).
Review checklist (to be filled by reviewers)