Repository navigation
Wait for emulator boot before running instrumented tests - #662
Merged
Merged
Conversation
The emulator was started in the background and connectedDebugAndroidTest ran immediately, relying on the Gradle build taking longer than the boot. With build caching enabled the build often finishes first, and APK installation fails with "Can't find service: package". Build the APKs while the emulator boots, then poll sys.boot_completed (up to 300s) before running the connected tests. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
0xnm
marked this pull request as ready for review
October 19, 2026 08:21
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
There was a problem hiding this comment.
More details
The boot-completion gate addresses the APK installation race while preserving build, timeout, and test failure propagation. Actual Android emulator execution remains unvalidated.
🤖 Bits Code Review · Commit f5dccc5
kikoveiga
approved these changes
Oct 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
The emulator was started in the background and
connectedDebugAndroidTestran immediately, relying on the Gradle build taking longer than the boot. With build caching enabled the build often finishes first, and APK installation fails with "Can't find service: package".Build the APKs while the emulator boots, then poll
sys.boot_completed(up to 300s) before running the connected tests.Review checklist (to be filled by reviewers)