Repository navigation
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
![datadog-datadog-prod-us1-2[bot]](https://avatars.githubusercontent.com/u/365230?s=60&v=4){kind=small}
There was a problem hiding this comment.
More details
Variant-specific assembly supplies the artifacts expected by each upload test. Tests requiring all variants retain their aggregate builds and coverage.
🤖 Bits Code Review · Commit d1d5cfc
0xnm
added
the
ready-for-human-review
Upload functional tests pick a single random variant, but ran `assembleRelease` beforehand, which builds and R8-shrinks all 4 variants of the sample app. Run `assemble<Variant>Release` for the chosen variant only. Tests asserting on `assembleRelease` / `assembleDebug` themselves, the `bundleRelease` build ID test and the all-variants NDK upload test still build every variant. Locally the 13 affected tests go from 165s to 88s. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
0xnm
force-pushed
the
nogorodnikov/rum-19011/functional-tests-assemble-tested-variant
branch
from
October 19, 2026 09:11
d1d5cfc to
0091671
Compare
satween
approved these changes
Oct 19, 2026
0xnm
deleted the
nogorodnikov/rum-19011/functional-tests-assemble-tested-variant
branch
October 19, 2026 10:38
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Upload functional tests pick a single random variant, but ran
assembleReleasebeforehand, which builds and R8-shrinks all 4 variants (demo/fullxBlue/Green) of the sample app. They now runassemble<Variant>Releasefor the chosen variant only.Tests asserting on
assembleRelease/assembleDebugthemselves, thebundleReleasebuild ID test and the all-variants NDK upload test still build every variant.Motivation
test:pluginis the longest job in the pipeline (~16 min on average ondevelopover the last 30 days), andDdAndroidGradlePluginFunctionalTestaccounts for ~10.5 min of it.Locally, the 13 affected tests go from 165s to 88s (-47%).
Additional Notes
Other speed-up ideas (TestKit cache in CI, Magic Mirror proxy for test projects, separate CI job, deterministic AGP/Gradle configuration) are tracked as follow-ups in RUM-19011.
Review checklist (to be filled by reviewers)
🤖 Generated with Claude Code