Repository navigation
RUM-19005: Upload all packaged native libraries, skip stripped ones - #657
Conversation
|
@codex review |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
Security findingsAdvisory findings (1)
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 57bbbe65d1
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
There was a problem hiding this comment.
🛡️ Codex Security Review · Automatically triggered
Here are some automated security review suggestions for this pull request.
Reviewed commit: 57bbbe65d1
ℹ️ About Codex security reviews in GitHub
This is an experimental Codex feature. Security reviews are triggered when:
- You comment "@codex security review"
- A regular code review gets triggered (for example, "@codex review" or when a PR is opened), and you’re opted in so security review runs alongside code review
Once complete, Codex will leave suggestions, or a comment if no findings are found.
57bbbe6 to
7216c74
Compare
|
@codex review |
|
Codex Review: Didn't find any major issues. Keep it up! Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
🛡️ Codex Security Review · Automatically triggeredSecurity review completed. No security issues were found in this pull request. Reviewed commit: Only the user who started this review can view the report in Codex. ℹ️ About Codex security reviews in GitHubThis is an experimental Codex feature. Security reviews are triggered when:
Once complete, Codex will leave suggestions, or a comment if no findings are found. |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 7216c7429d
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
With the new Variant API, upload the native libraries from the variant's MERGED_NATIVE_LIBS artifact: everything packaged into the variant (built by the app, prebuilt jniLibs and AAR dependencies), after packaging excludes and before AGP strips them. The artifact carries the dependency on the tasks producing it, so the upload task no longer looks up native build tasks when it is configured, which could find none if it was configured early. Prebuilt and dependency libraries usually ship already stripped. Only their exported symbols could be symbolicated, and the backend keeps the first file per build ID, name and ABI, so a stripped copy could block the copy with symbols. Read the ELF section names of each .so and skip it when it has no .symtab, .debug_info or .zdebug_info. Files which can't be parsed are still uploaded. Warn when every library found was stripped. Also enable the NDK upload test with gzip disabled, which was missing @test and never disabled gzip. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
7216c74 to
911c215
Compare
![datadog-official[bot]](https://avatars.githubusercontent.com/in/1358509?s=60&v=4){kind=small}
There was a problem hiding this comment.
More details
The completed static review identified no reportable defect in artifact dependency wiring or stripped-library filtering. Runtime behavior remains unverified because tests were inspected but not executed.
🤖 Bits Code Review · Commit 7216c74
0xnm
added
the
ready-for-human-review
2 participants
What does this PR do?
With the new Variant API, upload the native libraries from the variant's
MERGED_NATIVE_LIBSartifact: everything packaged into the variant (built by the app, prebuiltjniLibsand AAR dependencies), after packaging excludes and before AGP strips them. The artifact carries the dependency on the tasks producing it, so the upload task no longer looks up native build tasks when it is configured, which could find none if it was configured early.Prebuilt and dependency libraries usually ship already stripped. Only their exported symbols could be symbolicated, and the backend keeps the first file per build ID, name and ABI, so a stripped copy could block the copy with symbols. Read the ELF section names of each
.soand skip it when it has no.symtab,.debug_infoor.zdebug_info. Files which can't be parsed are still uploaded. Warn when every library found was stripped.Also enable the NDK upload test with gzip disabled, which was missing
@Testand never disabled gzip.Review checklist (to be filled by reviewers)