Repository navigation
chore(deps): update dependency org.jetbrains.kotlin:kotlin-gradle-plugin to v2.4.20 [security] - #644
dd-octo-sts[bot] wants to merge 1 commit into
Conversation
…gin to v2.4.20 [security]
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: fa10e3e3d7
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
| # Commons | ||
| kotlin20 = "2.0.21" | ||
| kotlin21 = "2.1.21" | ||
| kotlin21 = "2.4.20" |
There was a problem hiding this comment.
Keep the Kotlin 2.1 compatibility slot on 2.1
This version key also supplies kotlinCompilerEmbeddable21 and kotlinGradlePlugin21, so the dd-sdk-android-gradle-plugin-kcp-kotlin21 module is now compiled against Kotlin 2.4.20 rather than 2.1.x. That module still imports and registers ComponentRegistrar, while the Kotlin 2.4 implementation explicitly documents that this API was removed in 2.4.20 and uses CompilerPluginRegistrar instead; consequently the test:kotlin21 CI job cannot compile the dedicated 2.1 module. Leave this compatibility slot on a 2.1 release; kotlin24 already provides the 2.4.20 dependency.
Useful? React with 👍 / 👎.
There was a problem hiding this comment.
The shared version update also upgrades the Kotlin 2.1 module’s compiler dependency to 2.4.20, which removed its required ComponentRegistrar API. This prevents the module from compiling.
🤖 Bits Code Review · Commit fa10e3e
| # Commons | ||
| kotlin20 = "2.0.21" | ||
| kotlin21 = "2.1.21" | ||
| kotlin21 = "2.4.20" |
There was a problem hiding this comment.
Preserve the Kotlin 2.1 compiler dependency
Building dd-sdk-android-gradle-plugin-kcp-kotlin21 now resolves kotlin-compiler-embeddable 2.4.20 because it shares this version entry. That compiler removed ComponentRegistrar, which the module still imports, registers with AutoService, and inherits through DatadogPluginRegistrar, so compilation fails and blocks building the plugin. Keep this artifact’s compiler dependency on a compatible 2.1 version and separate it from the Gradle-plugin security upgrade; that requires changing dependency references beyond this diff line.
Was this helpful? React 👍 or 👎
🤖 Bits Code Review · Open Bits AI session
This PR contains the following updates:
2.1.21→2.4.20Warning
Some dependencies could not be looked up. Check the warning logs for more information.
🚨 Security Vulnerability Fix
Severity: MEDIUM
This PR addresses a detected security vulnerability. Please review and merge promptly.