Skip to content

fix(sdk): portable $defs/semver end-anchor (#1766) #1767

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
FabioLeitao merged 1 commit into from
Aug 26, 2026
Merged

fix(sdk): portable $defs/semver end-anchor (#1766) #1767

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion docs/sdk/PLUGIN_CONTRACT.schema.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@
"$defs": {
"semver": {
"type": "string",
"pattern": "^[0-9]+\\.[0-9]+\\.[0-9]+([.-][A-Za-z0-9.-]+)?$"
"pattern": "^[0-9]+\\.[0-9]+\\.[0-9]+([.-][A-Za-z0-9.-]+)?(?![\\s\\S])"
},
"trust_level": {
"type": "string",
Expand Down
11 changes: 11 additions & 0 deletions tests/test_plugin_sdk_contract.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,6 +64,17 @@ def test_examples_validate_against_contract_schema(example_path: Path) -> None:
jsonschema.validate(instance=instance, schema=schema)


def test_semver_rejects_trailing_newline_on_python_jsonschema() -> None:
"""Python jsonschema uses re.search; `$` would accept a trailing newline. (#1766)"""
semver = _load_schema()["$defs"]["semver"]
jsonschema.validate(instance="1.0.0", schema=semver)
jsonschema.validate(instance="1.2.3-alpha.1", schema=semver)
with pytest.raises(jsonschema.ValidationError):
jsonschema.validate(instance="1.0.0\n", schema=semver)
with pytest.raises(jsonschema.ValidationError):
jsonschema.validate(instance="1.0.0 ", schema=semver)


def test_invalid_decision_fails_schema() -> None:
schema = _load_schema()
bad = {
Expand Down