Add last updated date to hero stats in German and Chinese locales #49
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
deandzhwere left incomplete after the "hero stats last updated" feature was merged intomain(that PR landed after both locale PRs), plus a related bug in how release dates are formatted for languages without a hardcoded month list.Changes
public/locales/de/home.json/public/locales/zh/home.json: added the missinghero.stat.updatedkey ("Letzte Aktualisierung: {{date}}"/"最后更新：{{date}}").components/community/routes/HomeRoute.tsx:fmtDate()(used for GitHub release dates in the activity section) hardcoded month abbreviations only fores/en/ptand silently fell back to Spanish for any other language. Now it falls back toIntl/toLocaleStringfor languages without an explicit entry, sode/zh(and any future locale) format correctly — e.g.de→Mai 2026,zh→2026年5月(correct year-first order) instead of the Spanishmay 2026.es/en/ptoutput is unchanged.