Add issue templates, CODEOWNERS, and commit/PR conventions - #90
Merged
Conversation
Record the branch prefixes, imperative commit style, squash-merge default, Closes #N linking and AI co-author trailer already in use, and point the bug-report links at the template chooser. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Add bug-report and feature-request templates carrying the environment dimensions this plugin actually varies over, plus a redaction reminder for IP addresses, and assign review of every path to the maintainer. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
CHANGELOG.md currently has no [Unreleased] section, so pointing at one without saying to create it left the instruction unfollowable. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Member
Author
|
Self-review rubric, scored against the diff and command output rather than judgment:
Findings folded in from the diff read, none of them blocking:
This review comment was drafted during a Gardener session (https://github.com/Stephenson-Software/gardener). |
This was referenced Aug 9, 2026
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Three of the four artifact gaps recorded in #89 are closed here, along with that issue's
README.mdnit.CONTRIBUTING.mdnow documents the branch prefixes already in use (feature/,fix/,docs/,chore/, each with a real branch from this repository's history as its example), the imperative commit-subject style, the squash-merge default,Closes #<number>linking, the HEREDOC +Co-Authored-Bytrailer convention, and when aCHANGELOG.mdentry is expected. Step 8 of "Making Changes" previously asked only that the issue be linked "with#<number>", which does not close it on merge; it now specifiesCloses #<number>..github/ISSUE_TEMPLATE/bug_report.mdandfeature_request.mdwere added, with bracketed title tags matching thebugandimprovementlabels that already exist on this repository. The environment block asks for the dimensions this plugin actually varies over: plugin version, server software, Java version, database (H2 or MariaDB), and interacting plugins. Both templates carry a privacy prompt, since IP disclosure is the failure mode this plugin has been hardened against..github/CODEOWNERSwas added in the minimal* @dmccoystephensonform requested./issues/new/chooseso the new templates are offered.Two claims from the #89 audit were re-verified against the full history before being written down, since that audit ran against a shallow clone:
(#N)subjects), but28f4a7b— the most recent commit — is a merge commit, so the wording does not claim merge commits are only historical.Co-Authored-ByandCo-authored-byare in active use. Git matches trailer keys case-insensitively, so the doc names one preferred spelling and notes the other is equivalent rather than declaring existing commits wrong.Not in this pull request
CLAUDE.md) — deferred deliberately. Align repository with dms-conventions (CLAUDE.md, issue templates, CODEOWNERS, commit/PR conventions) #89 itself notes that a newCLAUDE.mdwould overlap.github/copilot-instructions.mdand that "the two should be reconciled rather than duplicated". That file is stale (tracked in .github/copilot-instructions.md is out of date (stale AafIpsCommand, missing encryption/ package, wrong test-framework status) #62) and editing agent-loaded configuration requires separate maintainer authorization, so writing a correctCLAUDE.mdnow would leave two agent-facing documents disagreeing with each other. Both are best done in one authorized pass.main) — not verifiable from this session; the repository administration API is outside this session's permissions. Confirmation is still requested from the maintainer.docker-buildCI job —.github/workflows/*is a protected path that is not modified autonomously in this repository.#89 is therefore referenced rather than closed, and a comment enumerating what remains will be left on it.
Test plan
plugin.yml,config.yml, migration, orbuild.gradlefile is touched — the change is Markdown documentation and GitHub repository metadata only.Buildworkflow passes on this pull request's head. It is the external anchor here; note that its scope does not extend to the changed files, none of which are compiled or executed.Part of #89.
This PR description was drafted during a Gardener session (https://github.com/Stephenson-Software/gardener).