Fix looping sounds - #1754
Fix looping sounds#1754VReaperV wants to merge 2 commits into
Conversation
55c203f to
33f5b4a
Compare
|
For me this branch seems to break all non-looping sounds. For example firing a rifle makes no sound. Anyway would this means we are perpetually mixing a bunch of dead sounds with 0 volume? Seems like it could cause performance problems |
33f5b4a to
82f6739
Compare
Fixed. |
I've found a fix for this as well. I'll open a new pr later to use instead of this one, since it requires compat-breaking changes. |
I've put the proper fix into #1756. |
Fixes the magical quantum looping sound emitters that change their state when you stop observing them.
The effect can be very easily heard on the map
spacetrackswhere the elevator music restarts whenever the speaker goes out of view without this fix.Also removed a layer of useless functions in the surrounding code.