review skill update: preflight, REST-first diff, fuse mode - #411
Merged
Conversation
Hardening from the skill's first real run (PR DOI-USGS#407): - Preflight step: REST-first diff acquisition via the public GitHub API (follow the EC-USGS -> DOI-USGS 301); gh is optional and its GraphQL paths are SAML-blocked for this org, so gh pr diff does not work. - Consolidate blocking questions into one poll and forbid proceeding on a documented default for an unanswered question. - Split the ground rules: the report file is the only permitted write, while read-only verification by execution is encouraged; pass both down to the built-in code-review sub-agents. - Permit read-only git under /review alongside the REST preference, and note that a diff vs upstream/develop is only as fresh as the last fetch. - Document fuse mode: a blind second pass plus a self-contained fused report with per-finding provenance and explicit reconciliation. - Sharpen Layer A from real misses: compare pytest flags in ci_local.sh and not just file lists, verify doc/api autosummary targets exist, and read a skip guard's presence-vs-value logic before calling a collected test a CI failure. CLAUDE.md: note the second-pass and fused report modes. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hardening from the skill's first real run (PR #407):
CLAUDE.md: note the second-pass and fused report modes.