Skip to content

review skill update: preflight, REST-first diff, fuse mode - #411

Merged
jmccreight merged 2 commits into
DOI-USGS:developfrom
jmccreight:review_skill
Aug 20, 2026
Merged

review skill update: preflight, REST-first diff, fuse mode#411
jmccreight merged 2 commits into
DOI-USGS:developfrom
jmccreight:review_skill

Conversation

@jmccreight

Copy link
Copy Markdown
Collaborator

Hardening from the skill's first real run (PR #407):

  • Preflight step: REST-first diff acquisition via the public GitHub API (follow the EC-USGS -> DOI-USGS 301); gh is optional and its GraphQL paths are SAML-blocked for this org, so gh pr diff does not work.
  • Consolidate blocking questions into one poll and forbid proceeding on a documented default for an unanswered question.
  • Split the ground rules: the report file is the only permitted write, while read-only verification by execution is encouraged; pass both down to the built-in code-review sub-agents.
  • Permit read-only git under /review alongside the REST preference, and note that a diff vs upstream/develop is only as fresh as the last fetch.
  • Document fuse mode: a blind second pass plus a self-contained fused report with per-finding provenance and explicit reconciliation.
  • Sharpen Layer A from real misses: compare pytest flags in ci_local.sh and not just file lists, verify doc/api autosummary targets exist, and read a skip guard's presence-vs-value logic before calling a collected test a CI failure.

CLAUDE.md: note the second-pass and fused report modes.

jmccreight and others added 2 commits August 20, 2026 16:11
Hardening from the skill's first real run (PR DOI-USGS#407):

- Preflight step: REST-first diff acquisition via the public GitHub API
  (follow the EC-USGS -> DOI-USGS 301); gh is optional and its GraphQL
  paths are SAML-blocked for this org, so gh pr diff does not work.
- Consolidate blocking questions into one poll and forbid proceeding on
  a documented default for an unanswered question.
- Split the ground rules: the report file is the only permitted write,
  while read-only verification by execution is encouraged; pass both
  down to the built-in code-review sub-agents.
- Permit read-only git under /review alongside the REST preference, and
  note that a diff vs upstream/develop is only as fresh as the last fetch.
- Document fuse mode: a blind second pass plus a self-contained fused
  report with per-finding provenance and explicit reconciliation.
- Sharpen Layer A from real misses: compare pytest flags in ci_local.sh
  and not just file lists, verify doc/api autosummary targets exist, and
  read a skip guard's presence-vs-value logic before calling a collected
  test a CI failure.

CLAUDE.md: note the second-pass and fused report modes.

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
@jmccreight
jmccreight merged commit de51ec9 into DOI-USGS:develop Aug 20, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant