Skip to content

Bugfix: Tree offset in refine_every_nth_element_callback #2415

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
spenke91 wants to merge 2 commits into
base: main
Choose a base branch
from
+9 −5
Open

Bugfix: Tree offset in refine_every_nth_element_callback #2415

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5ab6197
Bugfix: Tree offset in refine_every_nth_element_callback
spenke91 Sep 1, 2026
246d5dc
Switch to global ID
spenke91 Sep 1, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 9 additions & 5 deletions test/t8_gtest_adapt_callbacks.hxx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,12 +54,12 @@ t8_test_adapt_first_child (t8_forest_t forest, t8_forest_t forest_from, t8_locid
const int is_family, const int num_elements, t8_element_t *elements[]);

/**
* Adapt callback that refines every n-th local element, where \a n is given as template parameter.
* Adapt callback that refines every n-th global element, where \a n is given as template parameter.
*
* Optionally, an \a offset < \a n may be defined to not start with the first local leaf eleement.
* Optionally, an \a offset < \a n may be defined to not start with the first leaf eleement.
*
* \tparam n every n-th local leaf element will be refined
* \tparam offset local ID of the first element to refine
* \tparam n every n-th global leaf element will be refined
* \tparam offset global ID of the first element to refine
*
* Note: The argument list has to be the same as for \ref t8_forest_adapt_t, even
* if most arguments are unused. For their meaning, please refer to \ref t8_forest_adapt_t.
Expand All @@ -86,8 +86,12 @@ refine_every_nth_element_callback ([[maybe_unused]] t8_forest_t forest, [[maybe_
[[maybe_unused]] const int is_family, [[maybe_unused]] const int num_elements,
[[maybe_unused]] t8_element_t *elements[])
{
// Compute global element ID (forest offset + tree offset + id in tree).
t8_gloidx_t global_elem_id = t8_forest_get_first_local_leaf_element_id (forest_from)
+ t8_forest_get_tree_element_offset (forest_from, which_tree) + lelement_id;

// Refine every n-th element, starting from offset (default: zero).
return ((lelement_id % n == offset) ? 1 : 0);
return ((global_elem_id % n == offset) ? 1 : 0);
}

#endif /* T8_GTEST_ADAPT_CALLBACKS */
Loading