Deprecate validate parameter on Dataset - #961
Open
ecomodeller wants to merge 2 commits into
Open
Conversation
Dataset now always validates that its DataArrays have compatible shape, time, geometry, and dims. The validate parameter is deprecated with a FutureWarning when passed as False. Also fixes bugs in _is_compatible: - geometry was compared to itself instead of the other DataArray's - start_time comparison failed for relative time axes (TimedeltaIndex) - hasattr(__eq__) was always True (every object has __eq__)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
validate=FalseonDataset()andDataset.from_numpy()with aFutureWarning— Dataset now always validates consistency of its DataArraysvalidate=Falsecalls (~25 sites)_is_compatible:self.geometry == self.geometry) instead ofother.geometrystart_timecomparison crashed on relative time axes (TimedeltaIndex) — now comparestime[0]directlyhasattr(__, "__eq__")was always True — now only runs value comparison for geometries that override__eq__Validation overhead is ~33µs per Dataset creation (benchmarked) — negligible vs I/O.