Move closing-edge check outside loop in _point_in_polygon - #945
Open
ecomodeller wants to merge 2 commits into
Open
Move closing-edge check outside loop in _point_in_polygon#945ecomodeller wants to merge 2 commits into
ecomodeller wants to merge 2 commits into
Conversation
The closing edge (last→first vertex) was checked inside the loop, running n-1 redundant times. Move it after the loop. Add tests for point-in-polygon and element search correctness.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
The closing-edge check (last→first vertex) in _point_in_polygon was inside the inner loop, evaluating redundantly on every iteration. While functionally correct, the check is logically part of the polygon boundary test and belongs after the loop. Moving it out makes the code clearer about what each section does.
What this adds