Conversation
BanjoR
marked this pull request as ready for review
August 17, 2026 09:37
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Automatic issue closing
Fixes #308
Fixes #313
Issue #375 is broader network/DHCP behavior; this PR does not claim to close that full report.
Summary
Refresh W5100/W5500 Ethernet configuration and diagnostics for wired CommandStation builds:
Bounded scope and exclusions
The exact changed-file scope is limited to:
This change does not vendor or modify the Arduino Ethernet dependency, add Wi-Fi behavior, change the protocol/API, or include the ESP32 OTA/custom-server work from PR #525. The wired environments set ENABLE_WIFI=false and ENABLE_ETHERNET=true; the existing configuration also rejects simultaneous Wi-Fi and Ethernet. WIFI_SSID and WIFI_PASSWORD are not used for Ethernet.
The official Arduino Ethernet dependency requests DHCP when IP_ADDRESS is omitted but hard-codes its DHCP hostname option. ETHERNET_HOSTNAME is applied to DCC-EX mDNS/native STM32 naming and reported at startup; a custom W5500 DHCP hostname requires a dependency API/library update: https://github.com/arduino-libraries/Ethernet/blob/master/src/Dhcp.cpp
References
Authoritative issues:
Superseded or incomplete PRs:
Validation evidence
Host audit
python -m platformio runin a clean task checkout with an isolated PlatformIO core completed for all five configured environments:mega2560,ESP32,Nucleo-F411RE,Nucleo-F446RE, andNucleo-F429ZI.python -m platformio run -e ESP32-Ethernetafter the ESP32 Server API compatibility adapter: 22.15 seconds; RAM 27,304/327,680 (8.3%); Flash 497,301/1,310,720 (37.9%).GitHub Actions and required checks
Hardware validation
Hardware validation: Not run—no hardware available
Maintainer bench procedure: