Repository navigation
qa: install architecture guard package boundwize/structarmed - #843
Merged
Merged
Conversation
Closed
Contributor
Author
|
@romm ready to merge 👍 |
Contributor
Author
|
@romm if you need to include |
Member
|
As stated in #841 (comment), could you update the composer check and composer fix commands as well? |
Contributor
Author
boundwize/structarmed
Member
|
Good, thank you 😊 Now we can work on the rulesets! |
Contributor
Author
|
@romm sure, I created new PR for ruleset: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@romm here initial use of StructArmed with PSR4 Preset on QA.
This apply to Source layer that PSR4 preset scans:
qaandsrcdirectory to ease for gradual updates.Per I write at #841 (comment), there is nothing to showoff to just PSR4 preset on
qaandsrc, I can apply ontestsdirectory, but there are many multiple classes in single file which can be discussed later whether they are on purpose.