Order the face nodes of the enriched tetrahedron as Exodus does - #112
Merged
Merged
Conversation
The side-node table of the Exodus library (ex_get_side_set_node_list.c) assigns node 14 of a 15-node tetrahedron to side 1 (face 1-2-4), node 12 to side 2 (2-3-4), node 13 to side 3 (1-4-3) and node 11 to side 4 (1-3-2). The face nodes were numbered in side order. They now follow the Exodus convention, so a TETRA15 block written by any Exodus producer is read without a permutation. boundary_dofs returns the face node of each side accordingly. Signed-off-by: Alejandro Mota <amota@sandia.gov>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #112 +/- ##
=======================================
Coverage 63.53% 63.53%
=======================================
Files 13 13
Lines 1744 1744
=======================================
Hits 1108 1108
Misses 636 636 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The side-node table of the Exodus library assigns node 14 of a 15-node tetrahedron to side 1, node 12 to side 2, node 13 to side 3 and node 11 to side 4.
Tet{EnrichedLagrange, 2}numbered its face nodes in side order; it now follows the Exodus convention, andboundary_dofsreturns the face node of each side accordingly. Version 0.14.8.