Skip to content

Fix accessibility: Open keyboard on TalkBack double-tap - #1074

Open
mieciuJP wants to merge 1 commit into
Crustack:mainfrom
mieciuJP:fix-talkback-keyboard
Open

Fix accessibility: Open keyboard on TalkBack double-tap#1074
mieciuJP wants to merge 1 commit into
Crustack:mainfrom
mieciuJP:fix-talkback-keyboard

Conversation

@mieciuJP

@mieciuJP mieciuJP commented Jul 24, 2026

Copy link
Copy Markdown

This PR fixes an accessibility issue for blind users relying on screen readers such as TalkBack. Previously, double-tapping on an EditText field would focus the element but fail to explicitly invoke the soft keyboard, preventing text entry. By overriding performClick() and onFocusChanged() and utilizing a new isEditableMode property, the keyboard is now reliably displayed on double-tap without conflicting with other focus listeners.

Summary by CodeRabbit

  • Bug Fixes
    • Improved keyboard display behavior when focusing or activating editable text fields.
    • Ensured keyboard interaction respects whether the field is currently editable.
    • Preserved existing text-watching and selection behavior across supported Android versions.

Overrides performClick and onFocusChanged to ensure the keyboard is shown when blind users double tap EditText fields using screen readers like TalkBack.
@coderabbitai

coderabbitai Bot commented Jul 24, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: 5d70809d-8633-49c3-a38f-5ff2de582c99

📥 Commits

Reviewing files that changed from the base of the PR and between 1fbbdb5 and a401e9d.

📒 Files selected for processing (1)
  • app/src/main/java/com/philkes/notallyx/presentation/view/misc/EditTextWithWatcher.kt

📝 Walkthrough

Walkthrough

EditTextWithWatcher removes SDK checks, tracks editable mode, and handles keyboard display through focus and click overrides while preserving text-watching and selection behavior.

Changes

Editable keyboard behavior

Layer / File(s) Summary
Editable mode and keyboard handling
app/src/main/java/com/philkes/notallyx/presentation/view/misc/EditTextWithWatcher.kt
The view tracks editability through setCanEdit and shows the keyboard from onFocusChanged and performClick when editable mode is enabled, replacing SDK-conditional listener setup.

Estimated code review effort: 2 (Simple) | ~10 minutes

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly matches the main change: fixing TalkBack accessibility by opening the keyboard on double-tap.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant