Conversation
Co-authored-by: Xavier Warmerdam <xavwar1@gmail.com>
|
Cursor Agent can help with this pull request. Just |
Greptile SummaryThis PR adds an Confidence Score: 4/5
Important Files Changed
Prompt To Fix All With AIThis is a comment left during a code review.
Path: AGENTS.md
Line: 21
Comment:
**Incorrect version number**
The pinned version stated here (`4.18.0`) does not match the actual value in `fern/fern.config.json`, which is currently `4.38.0`. A developer following this guide who manually checks the config file will see a different version, which could cause confusion.
```suggestion
- The Fern CLI version is pinned in `fern/fern.config.json` (`"version": "4.38.0"`). Running `npm install -g fern-api` installs whatever version is specified there.
```
How can I resolve this? If you propose a fix, please make it concise.Reviews (2): Last reviewed commit: "Merge branch 'main' into cursor/developm..." | Re-trigger Greptile |
| - `fern docs dev` starts a backend on port 3001 and a frontend on port 3000. The first startup takes ~20-30 seconds to bootstrap the docs preview bundle. | ||
| - `fern check` may report warnings (e.g. about unused types); 0 errors is the passing criterion used in CI. | ||
| - Publishing and preview generation require a `FERN_TOKEN` environment variable (not needed for local dev or `fern check`). | ||
| - The Fern CLI version is pinned in `fern/fern.config.json` (`"version": "4.18.0"`). Running `npm install -g fern-api` installs whatever version is specified there. |
There was a problem hiding this comment.
Incorrect claim about npm install -g fern-api
The statement "Running npm install -g fern-api installs whatever version is specified there" is inaccurate. npm install -g fern-api always installs the latest version published to the npm registry — it does not read fern/fern.config.json to resolve the pinned version (4.18.0).
A developer following this guide would likely end up with a mismatched CLI version, which can cause subtle incompatibilities at runtime. To install the exact pinned version, the command should explicitly include the version tag:
| - The Fern CLI version is pinned in `fern/fern.config.json` (`"version": "4.18.0"`). Running `npm install -g fern-api` installs whatever version is specified there. | |
| - The Fern CLI version is pinned in `fern/fern.config.json` (`"version": "4.18.0"`). To install the exact pinned version, run `npm install -g fern-api@4.18.0`. |
Prompt To Fix With AI
This is a comment left during a code review.
Path: AGENTS.md
Line: 21
Comment:
**Incorrect claim about `npm install -g fern-api`**
The statement "Running `npm install -g fern-api` installs whatever version is specified there" is inaccurate. `npm install -g fern-api` always installs the **latest** version published to the npm registry — it does not read `fern/fern.config.json` to resolve the pinned version (`4.18.0`).
A developer following this guide would likely end up with a mismatched CLI version, which can cause subtle incompatibilities at runtime. To install the exact pinned version, the command should explicitly include the version tag:
```suggestion
- The Fern CLI version is pinned in `fern/fern.config.json` (`"version": "4.18.0"`). To install the exact pinned version, run `npm install -g fern-api@4.18.0`.
```
How can I resolve this? If you propose a fix, please make it concise.
Add
AGENTS.mdwith development environment setup instructions.