Repository navigation
Docs: man page, CONTRIBUTING, per-service examples, troubleshooting - #28
Merged
Merged
Conversation
) - man/sourceknock.1: hand-written roff man page; 'make install' now ships it alongside the systemd units (Linux-only install target). - CONTRIBUTING.md: build, make test, clang-format 17.0.6, fuzz target, e2e test (Linux/root), and the one-issue-one-branch PR workflow. - examples/: ssh.conf (close_on_connect), web.conf (multi-port close_on_connect), udp/wireguard.conf (UDP). All parse via the daemon's config loader. - Fix examples/sourceknock.conf: it used inline comments on value lines, which the parser does not strip, so it failed to parse. - README: Troubleshooting section (privileges, nftables, IPv6, inspecting the nft set), with a note that inline comments are not stripped. Closes #22.
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fills the gaps in issue #22 without duplicating the README:
cc -O2 -Wall -Wextra -std=gnu11 -isysroot /Library/Developer/CommandLineTools/SDKs/MacOSX15.2.sdk -Isrc -c src/capture.c -o src/capture.o now ships it alongside the systemd units (same Linux-only install target).
== state machine tests ==
[run] test_success_sequence
[run] test_wrong_port_resets
[run] test_window_timeout
[run] test_ignores_first_wrong
[run] test_find
[run] test_ipv6_keyed
25 passed, 0 failed
== packet parsing tests ==
[run] test_tcp
[run] test_udp
[run] test_loopback
[run] test_non_ipv4_ignored
[run] test_too_short
[run] test_tcp_v6
[run] test_loopback_v6
[run] test_v6_ext_header_walk
33 passed, 0 failed
== config parser tests ==
[run] test_good
[run] test_udp_close
[run] test_bad_sequence
[run] test_missing_sequence
[run] test_bad_protocol
[run] test_bad_port
[run] test_multi_trigger
[run] test_multi_trigger_missing_seq
[run] test_single_port
[run] test_multi_port
[run] test_bad_ports
[run] test_permanent_mode
[run] test_permanent_no_admin
[run] test_bad_mode
67 passed, 0 failed
== close decision tests ==
[run] test_close_only_when_armed
[run] test_arming_knock_does_not_close
[run] test_dport_must_match
[run] test_only_close_on_connect_mode
[run] test_port_in_list
8 passed, 0 failed
ALL GREEN, clang-format -i src/capture.c src/close.c src/config.c src/packet.c src/reward.c src/sourceknock.c src/state.c src/capture.h src/close.h src/config.h src/packet.h src/reward.h src/state.h tests/close_test.c tests/config_test.c tests/packet_test.c tests/state_test.c tests/test.h tests/fuzz/seed_check.c tests/fuzz/fuzz_pkt_parse.cc (clang-format 17.0.6), fuzz target, e2e test (Linux/root), and the one-issue-one-branch PR workflow.
Closes #22