Repository navigation
Fix e2e CI: nftables package + hermetic temp dir (#18) - #27
Merged
Merged
Conversation
The 'nft' package does not exist on the GitHub ubuntu runner; the nftables userspace CLI is provided by the 'nftables' package in the main repo. Closes #18.
The runner has no /tmp/skdev, so the listener's log/ready paths failed. Use mktemp -d for all scratch files, require the ready path arg in listener.py, and print daemon/listener logs on failure. Closes #18
Crank-Git
changed the title
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The e2e CI step ran
apt-get install -y nft, but thenftpackage does not exist on the GitHub ubuntu runner. The nftables userspace CLI is provided by thenftablespackage in the main repo, so install that instead.Closes #18