Merge master into y-course-refactor

[Purplegaze]

Proposed Changes

Merges changes that were made to the master branch since the offshoot split of y-course-refactor.

...

Screenshots of your changes (if applicable)

Type of Change

(Write an X or a brief description next to the type or types that best describe your changes.)

Type	Applies?
🚨 Breaking change (fix or feature that would cause existing functionality to change)
✨ New feature (non-breaking change that adds functionality)
🐛 Bug fix (non-breaking change that fixes an issue)
🎨 User interface change (change to user interface; provide screenshots)
♻️ Refactoring (internal change to codebase, without changing functionality)
🚦 Test update (change that only adds or modifies tests)
📦 Dependency update (change that updates a dependency)
🔧 Internal (change that only affects developers or continuous integration)	X

Checklist

(Complete each of the following items for your pull request. Indicate that you have completed an item by changing the [ ] into a [x] in the raw text, or by clicking on the checkbox in the rendered description on GitHub.)

Before opening your pull request:

• I have performed a self-review of my changes.
  • Check that all changed files included in this pull request are intentional changes.
  • Check that all changes are relevant to the purpose of this pull request, as described above.
• I have added tests for my changes, if applicable.
  • This is required for all bug fixes and new features.
• I have updated the project documentation, if applicable.
  • This is required for new features.
• If this is my first contribution, I have added myself to the list of contributors.
• I have updated the project Changelog (this is required for all changes).

After opening your pull request:

• I have verified that the CircleCI checks have passed.
• I have requested a review from a project maintainer.

Questions and Comments

I've noticed that unlike the other fields (which the last FromJSON Time' tests show), FromJSON Time' doesn't return Nothing if there's no sessionCode value. Instead, a Time' object with timeSession' = Nothing is returned. Is this an issue?

[coveralls]

Coverage Report for CI Build 21

Coverage increased (+1.2%) to 58.628%

Details

• Coverage increased (+1.2%) from the base build.
• Patch coverage: 51 uncovered changes across 10 files (82 of 133 lines covered, 61.65%).
• 93 coverage regressions across 6 files.

Uncovered Changes

File	Changed	Covered	%
app/Models/Course.hs	35	19	54.29%
app/Models/Graph.hs	25	13	52.0%
app/WebParsing/ArtSciParser.hs	11	0	0.0%
app/MasterTemplate.hs	4	0	0.0%
app/Models/Building.hs	26	23	88.46%
app/Config.hs	1	0	0.0%
app/Database/CourseVideoSeed.hs	1	0	0.0%
app/Database/Migrations.hs	3	2	66.67%
app/Svg/Parser.hs	4	3	75.0%
app/Util/Matrix.hs	5	4	80.0%
Total (13 files)	133	82	61.65%

Coverage Regressions

93 previously-covered lines in 6 files lost coverage.

File	Lines Losing Coverage	Coverage
app/Svg/Parser.hs	38	62.57%
app/WebParsing/ArtSciParser.hs	27	0.0%
app/Models/Course.hs	10	53.95%
app/Database/Tables.hs	9	72.86%
app/Models/Meeting.hs	5	21.88%
app/Util/Blaze.hs	4	0.0%

---

Coverage Stats

Relevant Lines:	3939
Covered Lines:	2367
Line Coverage:	60.09%
Relevant Branches:	946
Covered Branches:	497
Branch Coverage:	52.54%
Branches in Coverage %:	Yes
Coverage Strength:	164.46 hits per line

---

💛 - Coveralls