ci(dashboard): add accessibility validation to the pipeline#72
Open
shaaibu7 wants to merge 1 commit into
Open
Conversation
Catch common UI accessibility issues before deployment by auditing key components with axe-core and gating pull requests on critical violations. - Add a dedicated a11y suite (src/a11y) that renders the wallet button, event filters, event card/list and panel and validates them with jest-axe, plus a reusable audit helper. - Generate a readable Markdown report (a11y-report.md) covering every audited component, written even when audits fail. - Fail the build only on critical-impact violations; lesser findings are reported but non-blocking. - Add an "Accessibility (axe audit)" CI job that runs on pull requests via `npm run test:a11y` and uploads the report as an artifact. - Run the suite through its own jest.a11y.config.cjs and exclude it from the default test run. Also repair the corrupted dashboard package-lock.json (several hand-inserted dependency entries were missing closing braces, which broke `npm ci`), de-duplicate package.json devDependencies, and wire the @testing-library/jest-dom matcher types into tsc so the build passes.
shaaibu7
force-pushed
the
feat/notification-types-and-a11y-ci
branch
from
6285700 to
7973484
Compare
shaaibu7
changed the title
Collaborator
|
please fix CI and resolve conflicts please |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #40
Integrate accessibility validation into the CI pipeline to catch common UI issues before deployment.
What changed
dashboard/src/a11y/) renders the key UI surfaces — the wallet connect button (disconnected / connected / error states), event filters bar, event card, event list, and event list panel — and validates them withjest-axe(axe-core), plus a reusable audit helper. It runs through its ownjest.a11y.config.cjsvianpm run test:a11yand is excluded from the default test run.Accessibility (axe audit)job in.github/workflows/ci.ymlruns on every PR.a11y-report.md(per-component results plus an impact-count table), written even when audits fail, and uploaded as a CI artifact (if: always()).critical-impact violations only; lesser findings are reported but non-blocking. Both paths were verified (7 audits pass; a deliberate critical violation fails with a readable message).Incidental fixes (required to make the frontend pipeline run)
dashboard/package-lock.json— several hand-inserted dependency entries were missing closing braces, which brokenpm ci.package.jsondevDependencies.@testing-library/jest-dommatcher types intotscsonpm run buildpasses.Verification
Locally green:
npm ci,npm run lint,npm run build,npm test, andnpm run test:a11y.🤖 Generated with Claude Code