ci(listener): add lint and typecheck scripts#165
Merged
Abd-Standard merged 1 commit intoJun 22, 2026
Conversation
The CI workflow runs `npm run lint` and `npm run typecheck` in the listener, but neither script existed in package.json, so the Listener job failed immediately with `Missing script: "lint"` before tests ran. Add both scripts running the TypeScript compiler in no-emit mode as the static-analysis gate. (eslint is not currently wired up for the listener and its peer deps conflict with the package's TypeScript 6.x toolchain; a fuller eslint setup can be layered on later without changing CI.) This unblocks the Listener CI job. Combined with the two test fixes (preferences endpoint and rate-limit metrics), the job runs green.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The CI workflow's Listener job runs:
…but
listener/package.jsondefines neitherlintnortypecheck, so the job dies immediately at the first step withMissing script: "lint"— before tests ever run. This is why the Listener check is red on every PR.This PR adds both scripts, running the TypeScript compiler in
--noEmitmode as the static-analysis gate:Relationship to the test fixes
This unblocks the lint/typecheck steps. The test step also needs two pre-existing bug fixes to pass:
events-server.test.ts)rate-limiter.test.ts)With all three merged, the Listener job runs fully green. Recommended merge order: #162 and #163 first (so tests pass), then this PR.
Verification