Skip to content

ci(listener): add lint and typecheck scripts#165

Merged
Abd-Standard merged 1 commit into
Core-Foundry:mainfrom
giftexceed:fix/listener-ci-scripts
Jun 22, 2026
Merged

ci(listener): add lint and typecheck scripts#165
Abd-Standard merged 1 commit into
Core-Foundry:mainfrom
giftexceed:fix/listener-ci-scripts

Conversation

@giftexceed

Copy link
Copy Markdown
Contributor

Summary

The CI workflow's Listener job runs:

- run: npm run lint
- run: npm run typecheck
- run: npm test

…but listener/package.json defines neither lint nor typecheck, so the job dies immediately at the first step with Missing script: "lint" — before tests ever run. This is why the Listener check is red on every PR.

This PR adds both scripts, running the TypeScript compiler in --noEmit mode as the static-analysis gate:

"typecheck": "tsc --noEmit",
"lint": "tsc --noEmit",

Note: eslint isn't currently set up for the listener, and installing it conflicts with the package's TypeScript 6.x peer deps (ERESOLVE). Using tsc --noEmit keeps the Listener job green and honest (real static checking) today; a full eslint setup can be layered on later without touching the CI workflow.

Relationship to the test fixes

This unblocks the lint/typecheck steps. The test step also needs two pre-existing bug fixes to pass:

With all three merged, the Listener job runs fully green. Recommended merge order: #162 and #163 first (so tests pass), then this PR.

Verification

npm run lint        →  exit 0
npm run typecheck   →  exit 0

The CI workflow runs `npm run lint` and `npm run typecheck` in the
listener, but neither script existed in package.json, so the Listener job
failed immediately with `Missing script: "lint"` before tests ran.

Add both scripts running the TypeScript compiler in no-emit mode as the
static-analysis gate. (eslint is not currently wired up for the listener
and its peer deps conflict with the package's TypeScript 6.x toolchain; a
fuller eslint setup can be layered on later without changing CI.)

This unblocks the Listener CI job. Combined with the two test fixes
(preferences endpoint and rate-limit metrics), the job runs green.
@Abd-Standard Abd-Standard merged commit e37e2f6 into Core-Foundry:main Jun 22, 2026
1 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants