fix: deduplicate dashboard notification events#144
Merged
Abd-Standard merged 1 commit intoJun 22, 2026
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes duplicate notification rendering after rapid refreshes by deduplicating dashboard events before they reach the render layer.
Changes
eventIdin the dashboard event store.setEventsandappendEventsso refresh payloads and appended updates cannot create duplicate rendered entries.Testing/Verification
npm ci --ignore-scriptsfromdashboard/passed. Plainnpm cihits a Windows-incompatible transitive postinstall command (yarn setup || true) unrelated to this change.npm test -- --runTestsByPath src/store/eventStore.test.tsx --runInBandpassed.npm test -- --runInBandpassed: 5 suites / 22 tests.npm run buildpassed. Vite reported pre-existing duplicate devDependency key warnings indashboard/package.json.node ./node_modules/eslint/bin/eslint.js "src/**/*.{ts,tsx}" --max-warnings=0passed. The packagenpm run lintscript uses Unix single-quoted globs, which fail on Windows.Related issue: closes #134