Skip to content

fix: deduplicate dashboard notification events#144

Merged
Abd-Standard merged 1 commit into
Core-Foundry:mainfrom
CleanDev-Fix:fix/duplicate-notification-rendering-134
Jun 22, 2026
Merged

fix: deduplicate dashboard notification events#144
Abd-Standard merged 1 commit into
Core-Foundry:mainfrom
CleanDev-Fix:fix/duplicate-notification-rendering-134

Conversation

@CleanDev-Fix

Copy link
Copy Markdown
Contributor

Summary

Fixes duplicate notification rendering after rapid refreshes by deduplicating dashboard events before they reach the render layer.

Changes

  • Added event deduplication by stable eventId in the dashboard event store.
  • Applied deduplication to both setEvents and appendEvents so refresh payloads and appended updates cannot create duplicate rendered entries.
  • Added regression tests covering duplicate render input and repeated append data.

Testing/Verification

  • npm ci --ignore-scripts from dashboard/ passed. Plain npm ci hits a Windows-incompatible transitive postinstall command (yarn setup || true) unrelated to this change.
  • npm test -- --runTestsByPath src/store/eventStore.test.tsx --runInBand passed.
  • npm test -- --runInBand passed: 5 suites / 22 tests.
  • npm run build passed. Vite reported pre-existing duplicate devDependency key warnings in dashboard/package.json.
  • node ./node_modules/eslint/bin/eslint.js "src/**/*.{ts,tsx}" --max-warnings=0 passed. The package npm run lint script uses Unix single-quoted globs, which fail on Windows.

Related issue: closes #134

@Abd-Standard Abd-Standard merged commit bc6a790 into Core-Foundry:main Jun 22, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug] Fix Duplicate Notification Rendering

2 participants