-
Notifications
You must be signed in to change notification settings - Fork 0
fix(a11y): make advertised modal Escape shortcuts real #664
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
seonghobae
wants to merge
16
commits into
develop
Choose a base branch
from
palette-add-aria-keyshortcuts-to-modals-8514074320206895107
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Changes from all commits
Commits
Show all changes
16 commits
Select commit
Hold shift + click to select a range
78eb6d9
🎨 Palette: 모달 닫기 버튼에 키보드 단축키 힌트 추가
seonghobae cbba688
chore(ui): drop unrelated module preload change
seonghobae c55f597
test(a11y): require advertised cloud Escape shortcut
seonghobae 7c90c0a
chore(a11y): restore canonical Palette doctrine
seonghobae 5ac5f63
fix(a11y): execute cloud modal Escape shortcuts
seonghobae cb004a3
fix(a11y): load cloud modal keyboard controller
seonghobae 8957a52
test(a11y): verify cloud modal focus and Escape lifecycle
seonghobae b88841a
docs(a11y): trace cloud modal keyboard contract
seonghobae 370a998
fix(a11y): contain cloud modal keyboard focus
seonghobae 5715a1b
test(a11y): verify modal focus containment and dismissal paths
seonghobae 7b46573
docs(a11y): include modal focus containment acceptance
seonghobae 2313e92
🎨 Palette: 모달 닫기 버튼에 키보드 단축키 힌트 추가
seonghobae 3537839
fix(a11y): restore implemented cloud modal keyboard contract
seonghobae 350efc2
🎨 Palette: 모달 닫기 버튼에 키보드 단축키 힌트 추가
seonghobae f22e462
🎨 Palette: 모달 닫기 버튼에 키보드 단축키 힌트 추가
seonghobae fd1a562
🎨 Palette: 모달 닫기 버튼에 키보드 단축키 힌트 추가
seonghobae File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.