Skip to content

fix(a11y): mark generated user text for automatic direction - #633

Draft
seonghobae wants to merge 8 commits into
masterfrom
palette/bidi-text-support-3414937352910383179
Draft

fix(a11y): mark generated user text for automatic direction#633
seonghobae wants to merge 8 commits into
masterfrom
palette/bidi-text-support-3414937352910383179

Conversation

@seonghobae

@seonghobae seonghobae commented Sep 5, 2026

Copy link
Copy Markdown
Collaborator

Current exact authority

  • protected base: master@728f0f33323e43573d6664209891099502827d5d
  • exact head: 9d4e5120e9a47b11e19a043dac89ad5226bf0a76
  • ancestry: ahead 3 / behind 0; merge base is exact protected master
  • effective delta: src/main/kotlin/html4tree/main.kt, src/test/kotlin/html4tree/MainTest.kt, and src/test/kotlin/html4tree/BidiTextDirectionTest.kt
  • generated .jules/palette.md doctrine was restored byte-for-byte to protected authority and is no longer in the effective range
  • lifecycle: Draft; exact-head hosted and real-browser/a11y evidence remains non-terminal/absent

Review → causal repair

The initial branch correctly identified directionality as a product concern, but it also promoted a local implementation choice into repository-wide generated Palette doctrine and described dir="auto" as if it guaranteed correct mixed-BiDi layout and screen-reader behavior. Those claims exceed the evidence.

Normal descendant 5e98a2bc648e3dec9344260121772dd154a3d5b1 keeps the product source/test delta while restoring .jules/palette.md to the exact protected blob. Test successor 9d4e5120e9a47b11e19a043dac89ad5226bf0a76 adds an actual Arabic directory name (ملف) and Hebrew filename (מסמך.txt) and requires the generated <title>, <h1>, and visible filename span to carry dir="auto". No force-push, destructive rebase, or doctrine promotion was used.

Standards boundary

The WHATWG HTML dir contract defines auto as content-derived directionality and uses the first strong-direction character as its heuristic. That makes dir="auto" a reasonable source-level admission mechanism when the direction of user-controlled names is not known in advance, but the heuristic is deliberately limited. This PR therefore does not claim that arbitrary mixed-direction strings, browser chrome title rendering, tooltips, or assistive technologies are fully verified merely because the attribute exists.

Remaining acceptance

Before Ready, run one unchanged exact head through repository CI/security/SAST/CodeQL and exercise representative LTR, RTL, mixed Latin+Arabic/Hebrew, punctuation/digit-leading, and CJK names in a real browser. Verify visible order, generated filename links, keyboard navigation, accessibility-tree names, narrow viewport overflow/wrap, and that the Korean suffix in the document title remains understandable when the user-controlled name determines RTL direction. Do not infer screen-reader correctness from source-string assertions alone.

Fresh exact-head workflows are currently non-terminal: CI 33992067408, Security Scan 33992067402, CodeQL PR 33992067391, and SAST Semgrep 33992067382 are queued. Predecessor results do not transfer.

Delivery Gate

  • 의도성: PASS — unknown-direction user-controlled names are explicitly isolated at their rendered text containers.
  • 기능 완전성: PARTIAL — source and real RTL-name fixture exist; exact-head hosted and browser execution are pending.
  • 콘텐츠 적합성: PASS — branch-specific repository doctrine was removed from the effective delta.
  • 복원력: PARTIAL — Arabic/Hebrew source fixture is covered, but mixed-direction, narrow-view and real-browser behavior remain unverified.
  • 증거성: FAIL/PENDING — no current accessibility-tree or assistive-technology/browser evidence supports a blanket accessibility claim.
  • 고유성: N/A — directionality repair, not visual-brand work.

Keep Draft until the remaining exact-head and browser evidence is valid. No self-approval, bypass, gate weakening, force update, destructive rebase, or blanket WCAG/accessibility-compliance claim.

사용자가 제어하는 동적 텍스트(파일 이름, 디렉토리 이름)가 삽입되는 HTML 요소에
dir="auto" 속성을 추가하여 아랍어, 히브리어 등 양방향 텍스트(BiDi) 혼합 시
레이아웃과 텍스트 순서가 깨지는 현상을 방지합니다.
@google-labs-jules

Copy link
Copy Markdown

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

@coderabbitai

coderabbitai Bot commented Sep 5, 2026

Copy link
Copy Markdown

Important

Draft PR not reviewed

Draft PRs are not automatically reviewed by default.

  • Trigger a manual review

To automatically review draft PRs, update your CodeRabbit configuration:

reviews:
  auto_review:
    drafts: true

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@seonghobae seonghobae changed the title 🎨 Palette: [양방향 텍스트(BiDi) 지원을 위한 UX/접근성 향상] fix(a11y): mark generated user text for automatic direction Sep 5, 2026
@seonghobae
seonghobae marked this pull request as draft September 5, 2026 21:08
사용자가 제어하는 동적 텍스트(파일 이름, 디렉토리 이름)가 삽입되는 HTML 요소에
dir="auto" 속성을 추가하여 아랍어, 히브리어 등 양방향 텍스트(BiDi) 혼합 시
레이아웃과 텍스트 순서가 깨지는 현상을 방지합니다.
사용자가 제어하는 동적 텍스트(파일 이름, 디렉토리 이름)가 삽입되는 HTML 요소에
dir="auto" 속성을 추가하여 아랍어, 히브리어 등 양방향 텍스트(BiDi) 혼합 시
레이아웃과 텍스트 순서가 깨지는 현상을 방지합니다.
사용자가 제어하는 동적 텍스트(파일 이름, 디렉토리 이름)가 삽입되는 HTML 요소에
dir="auto" 속성을 추가하여 아랍어, 히브리어 등 양방향 텍스트(BiDi) 혼합 시
레이아웃과 텍스트 순서가 깨지는 현상을 방지합니다.
사용자가 제어하는 동적 텍스트(파일 이름, 디렉토리 이름)가 삽입되는 HTML 요소에
dir="auto" 속성을 추가하여 아랍어, 히브리어 등 양방향 텍스트(BiDi) 혼합 시
레이아웃과 텍스트 순서가 깨지는 현상을 방지합니다.
사용자가 제어하는 동적 텍스트(파일 이름, 디렉토리 이름)가 삽입되는 HTML 요소에
dir="auto" 속성을 추가하여 아랍어, 히브리어 등 양방향 텍스트(BiDi) 혼합 시
레이아웃과 텍스트 순서가 깨지는 현상을 방지합니다.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant