refactor(ignore): defer filename normalization after cheap exclusions - #618
refactor(ignore): defer filename normalization after cheap exclusions#618seonghobae wants to merge 2 commits into
Conversation
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
|
Warning Review limit reachedNext included review available in 12 minutes. View limit detailsLimit details: You’ve used the included review currently available. You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Review configuration: ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Team Run ID: 📒 Files selected for processing (1)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
seonghobae
changed the title
1 participant
Current exact authority
master@55b39b4ebad435670f26ec8065dfc980950e090ec9168895cba0d9dccde33efeb978a165be90ba1csrc/main/kotlin/html4tree/main.ktVerified semantic delta
The ignore-policy pass now checks two cheap cases first—dot-like hidden names and the literal
~suffix—and computestoLowerCase(Locale.ROOT)only for names that still need case-insensitive sensitive-name/extension checks. The intended semantics remain unchanged: all previously excluded hidden, backup-suffix, sensitive-name and sensitive-extension entries must still be excluded.This establishes a conditional-allocation refactor, not a buyer-visible performance result. It is true at source level that entries rejected by the first two branches no longer execute
toLowerCase(). That does not by itself establish lower total allocation, lower GC pause time, lower elapsed time, or material improvement on a real directory workload.Repair in this lineage
The generated branch appended a repository-wide
.jules/bolt.mdrule prescribing this evaluation order generally and claimed that memory profiling had already established reduced allocation/GC overhead without a committed reproducible profile. Normal descendantc9168895c...restores the exact protected Bolt journal blob while preserving the local product refactor. No force update or destructive rebase was used.The branch also had no dedicated regression that proves semantic parity across the reordered branches. Before performance promotion, add focused tests covering hidden/dot-like names,
~suffixes, case variants of sensitive basenames, sensitive extensions, Unicode/CJK ordinary names, and names that satisfy more than one exclusion rule. If allocation/GC improvement is claimed, benchmark the old/new loop on representative directory-name distributions with the same JDK/Kotlin/JIT/GC/warm-up conditions and report allocation plus latency/throughput evidence. If the measured effect is negligible, keep this only as a readability/conditional-work refactor or revert to the simpler implementation.Promotion boundary
Remain Draft until one unchanged exact head has semantic-parity tests, current CI/JaCoCo/security/SAST/OSV/Scorecard evidence, and current review/thread admission. Do not use unit-test success as GC evidence, predecessor results, no-op retriggers, self-approval, force rewrite, or gate weakening.