Skip to content

🛡️ Sentinel: [security improvement] 입력 디렉토리 경로 길이 제한 추가 - #617

Closed
seonghobae wants to merge 2 commits into
masterfrom
security-enhancement-path-length-8530383431332703287
Closed

🛡️ Sentinel: [security improvement] 입력 디렉토리 경로 길이 제한 추가#617
seonghobae wants to merge 2 commits into
masterfrom
security-enhancement-path-length-8530383431332703287

Conversation

@seonghobae

@seonghobae seonghobae commented Sep 4, 2026

Copy link
Copy Markdown
Collaborator

No-valid-delta disposition

Fresh review found no defensible security contract in the generated topDir.length <= 4096 gate. Kotlin String.length is not a portable filesystem pathname limit, and rejecting an already-materialized 4,097-character string does not establish a realistic DoS/OOM boundary. Filesystem pathname limits and acceptance remain platform/filesystem dependent; buyer-facing crawl exhaustion must instead be measured through directory fan-out/count, generated bytes, filesystem calls, elapsed time and peak RSS.

Canonical repair remains #598 (repair: remove non-portable 4,096 pathname security limit), which already carries the portability regression, the removal of this exact arbitrary cap, and docs/product-technical-gap-baseline.md traceability for the real resource-exhaustion gap.

This branch's generated head 0e6714e008d067be11bd85497be3d439a44c3dbf added only the 4,096-character rejection, its unit test, and matching Sentinel doctrine. Normal descendant 803a3bdae0d4d45955c77ab23c7cb10d6ace2a21 restores the exact protected master@55b39b4ebad435670f26ec8065dfc980950e090e tree while preserving the generated commit in ancestry. The ref advanced with force=false; fresh protected-base comparison is ahead_by=2, behind_by=0, files=[].

Accordingly there is no remaining production/test/docs/contract delta to merge. This PR is closed as no valid delta, not as arbitrary duplicate cleanup. The valid concern—real crawl resource exhaustion—continues in #598 under platform-correct, measurable acceptance. No force rewrite, destructive rebase, scanner suppression, self-approval or gate weakening was used.

@google-labs-jules

Copy link
Copy Markdown

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

@coderabbitai

coderabbitai Bot commented Sep 4, 2026

Copy link
Copy Markdown

Warning

Review limit reached

Next included review available in 59 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used the included review currently available.

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Learn how review limits work.

Review configuration:

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Team

Run ID: 1e6621dc-dfbb-4ae1-ba5e-5ac2aa2fee32

📥 Commits

Reviewing files that changed from the base of the PR and between 55b39b4 and 0e6714e.

📒 Files selected for processing (3)
  • .jules/sentinel.md
  • src/main/kotlin/html4tree/main.kt
  • src/test/kotlin/html4tree/MainTest.kt

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@seonghobae seonghobae closed this Sep 4, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant