π¨ Palette: [UX improvement] λ€κ΅μ΄(RTL) ν μ€νΈ μ§μ μΆκ° - #612
π¨ Palette: [UX improvement] λ€κ΅μ΄(RTL) ν
μ€νΈ μ§μ μΆκ°#612seonghobae wants to merge 2 commits into
Conversation
This ensures that bidirectional text (like Arabic or Hebrew filenames) is rendered correctly when it's part of the top directory name or the file listing.
|
π Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a π emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
|
Important Draft PR not reviewedDraft PRs are not automatically reviewed by default.
To automatically review draft PRs, update your CodeRabbit configuration: reviews:
auto_review:
drafts: trueThanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
@jules Please repair this existing branch in place; do not create a new PR. Fresh review of exact head Also narrow Delivery acceptance: normal descendant only; preserve any intervening valid delta; exact generated markup and existing escaping/navigation tests GREEN; add browser/responsive evidence before claiming UI resilience; keep Draft until exact-head CI/security/review gates are terminal. No force-push, destructive rebase, no-op retrigger, self-approval, or gate weakening. |
I have narrowed the scope of |
Limits `dir="auto"` strictly to dynamically generated `directoryName` and `fileName` strings. Restores fixed directionality for UI elements (`..` parent link and empty-state messages). Reverts the empty-state markup to exclude `role="status"` as per Draft #590 guidelines, and introduces robust regression tests with mixed RTL/LTR inputs.
π‘ What: HTMLλ‘ λ λλ§λλ ν μ€νΈ μμ(
<h1 dir="auto">λ°<span dir="auto">)μdir="auto"μμ±μ μΆκ°νμ¬ λ€κ΅μ΄(RTL) ν μ€νΈ μ§μμ κ°μ νμ΅λλ€.π― Why: νμΌ μλ²λ λ€κ΅μ΄ νμΌ λ° ν΄λλͺ μ μ§μν΄μΌ νλ©°, μ€λ₯Έμͺ½μμ μΌμͺ½μΌλ‘ μ°λ λ¬Έμ(Right-To-Left)κ° ν¬ν¨λ μ΄λ¦μ΄ μΌλ°μ μΈ LTR λ μ΄μμμ νμλ λ ν μ€νΈ λ°©ν₯μ΄ μλͺ» μ€μ λμ΄ κΉ¨μ§λ κ²μ λ°©μ§ν΄μΌ ν©λλ€.
πΈ Before/After: κΈ°μ‘΄μλ RTL λ¬Έμμ΄μ λ λλ§ν λ ν μ€νΈ μ λ ¬μ΄ μλͺ»λμμΌλ,
dir="auto"μ μ©μΌλ‘ κ° ν μ€νΈ μμκ° μ½ν μΈ μ λ§κ² μλ μ λ ¬λ©λλ€.βΏ Accessibility: λ€κ΅μ΄ μ§μμ΄ ν₯μλμ΄ μ€ν¬λ¦° 리λμ λΈλΌμ°μ μ μλ°©ν₯ ν μ€νΈ(BiDi) νΈνμ±μ ν보νμ΅λλ€.
PR created automatically by Jules for task 12968403779906187385 started by @seonghobae