Skip to content

fix(a11y): name directory navigation from a hidden heading #607

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
seonghobae wants to merge 3 commits into
base: master
Choose a base branch
from
Draft

fix(a11y): name directory navigation from a hidden heading #607

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
cb2aef8
접근성 개선: 내비게이션 영역을 aria-label에서 aria-labelledby로 변경
seonghobae Sep 3, 2026
1f15fe2
접근성 개선: 내비게이션 영역을 aria-label에서 aria-labelledby로 변경
seonghobae Sep 3, 2026
4435d48
docs(a11y): keep palette claims evidence-bounded
seonghobae Sep 4, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion src/main/kotlin/html4tree/main.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -427,7 +427,8 @@ fun process_dir(curr_dir: File, excludeSet: Set<String>? = null, dirFiles: Array
<body>
<main>
<h1>${directoryName.escapeHtml()}</h1>
<nav aria-label="디렉토리 목록">
<nav aria-labelledby="nav-heading">
<h2 id="nav-heading" class="visually-hidden">디렉토리 목록</h2>
Comment on lines +430 to +431

@devin-ai-integration devin-ai-integration Bot Sep 3, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔍 Accessibility guidance is now stale

Repository guidance still mandates <nav aria-label>, conflicting with aria-labelledby. Future changes can restore the superseded markup or reject this pattern.

Devin Review

Was this helpful? React with 👍 or 👎 to provide feedback.

<ul role="list">
<li><a class="dir-link" href="./.." title="상위 디렉토리로 이동"><span class="icon" aria-hidden="true">&#x21B0;</span> <span aria-hidden="true">..</span> <span class="visually-hidden">상위 디렉토리로 이동</span></a></li>
"""
Expand Down
3 changes: 2 additions & 1 deletion src/test/kotlin/html4tree/MainTest.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -331,7 +331,8 @@ class MainTest {
assertTrue(htmlContent.contains("<meta name=\"theme-color\" content=\"#ffffff\" media=\"(prefers-color-scheme: light)\">"))
assertTrue(htmlContent.contains("<meta name=\"theme-color\" content=\"#0d1117\" media=\"(prefers-color-scheme: dark)\">"))
assertRobotsDirective(htmlContent)
assertTrue(htmlContent.contains("<nav aria-label=\"디렉토리 목록\">"))
assertTrue(htmlContent.contains("<nav aria-labelledby=\"nav-heading\">"))
assertTrue(htmlContent.contains("<h2 id=\"nav-heading\" class=\"visually-hidden\">디렉토리 목록</h2>"))
assertTrue(htmlContent.contains("role=\"list\""))
assertTrue(htmlContent.contains("<main>"))
assertTrue(htmlContent.contains("</main>"))
Expand Down
Loading