forked from yencarnacion/html4tree
-
Notifications
You must be signed in to change notification settings - Fork 0
fix(ui): make pressed-link feedback visible on the rendered filename #599
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
seonghobae
wants to merge
18
commits into
master
Choose a base branch
from
palette-add-active-state-18334448428694167785
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Changes from all commits
Commits
Show all changes
18 commits
Select commit
Hold shift + click to select a range
8740795
🎨 Palette: [UX improvement] Add :active state to links
seonghobae c92d138
🎨 Palette: [UX 개선] 링크에 :active 상태 추가
seonghobae 76d6022
🎨 Palette: [UX 개선] 링크에 :active 상태 추가
seonghobae d90be1c
test(ui): target visible link text for active feedback
seonghobae 3e4f3bb
fix(ui): underline the visible entry name
seonghobae 8ecb57a
🎨 Palette: [UX 개선] 링크에 :active 상태 추가
seonghobae 25a4d26
🎨 Palette: [UX 개선] 링크에 :active 상태 추가
seonghobae 2dda26f
🎨 Palette: [UX 개선] 링크에 :active 상태 추가
seonghobae d5e21ba
🎨 Palette: [UX 개선] 링크에 :active 상태 추가
seonghobae 92eb0bc
🎨 Palette: [UX 개선] 링크에 :active 상태 추가
seonghobae 1f63c9e
🎨 Palette: [UX 개선] 링크에 :active 상태 추가
seonghobae dbc9917
fix(ui): restore semantic filename interaction target
seonghobae 31ddf8c
docs(palette): restore protected interaction guidance
seonghobae b811d47
merge(ui): restack filename interaction repair onto protected master
seonghobae a5516fc
🎨 Palette: [UX 개선] 링크에 :active 상태 추가
seonghobae 8d15f88
🎨 Palette: [UX 개선] 링크에 :active 상태 추가
seonghobae cf5b329
🎨 Palette: [UX 개선] 링크에 :active 상태 추가
seonghobae 2c8f78d
🎨 Palette: [UX 개선] 링크에 :active 상태 추가
seonghobae File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Some comments aren't visible on the classic Files Changed page.
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🔍 Regression test misses rendered filenames
The test generates no filename link and requires the positional selector. It cannot detect whether interactive underlining reaches rendered filenames.
(Refers to this code)
Was this helpful? React with 👍 or 👎 to provide feedback.