π¨ Palette: ν°λ―Έλ μΆλ ₯ λ° μλ¬ λ©μμ§ UX/DX κ°μ - #333
Conversation
|
π Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a π emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
There was a problem hiding this comment.
Pull request overview
This PR improves the AppGuardrail CLIβs terminal UX/accessibility by standardizing error/hint message prefixes (β Error:, π‘ Hint:) and fixing awkward pluralization in SBOM output.
Changes:
- Standardize CLI error and hint prefixes across scan/report/serve/dashboard/hook outputs.
- Add singular/plural handling for SBOM component counts (e.g.,
1 componentvs2 components). - Update unit tests to reflect the new output strings and minor formatting cleanups.
Reviewed changes
Copilot reviewed 3 out of 4 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
uv.lock |
Adds a uv lock file for the project (editable local package). |
tests/test_appguardrail.py |
Updates assertions for the new Error: / Hint: prefixed output; minor formatting cleanup. |
scanner/cli/appguardrail.py |
Implements standardized CLI prefixes and SBOM pluralization logic; includes some formatting-only changes. |
.jules/palette.md |
Documents the learned convention for standardized CLI prefixes and dynamic pluralization. |
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 3 out of 4 changed files in this pull request and generated 2 comments.
Comments suppressed due to low confidence (2)
scanner/cli/appguardrail.py:64
- Avoid using a backslash line continuation for imports; itβs inconsistent with the surrounding parenthesized-import style and is easy to break during edits. A single-line import fits here and is clearer.
from appguardrail_core.findings import \
is_deploy_blocking as core_is_deploy_blocking
scanner/cli/appguardrail.py:3046
- Same redundancy as above:
_console_print()already calls_format_msg()on strings, so the explicit_format_msg()wrapper is unnecessary and may lead to double-formatting in the future.
_console_print(
_format_msg(
f"\nπ‘ Hint: Run 'appguardrail review' to get an AI prompt for fixing {these_word}."
)
)
- μλ¬ λ©μμ§μ `β Error:` μ λμ΄ μΆκ° - ν λ©μμ§μ `π‘ Hint:` μ λμ΄ μΆκ° - `components` μΆλ ₯ μ λ¨μ/볡μ λμ μ²λ¦¬ μΆκ° - `.jules/palette.md` νμΌ μ λ°μ΄νΈ - κ΄λ ¨ ν μ€νΈ μ½λ 100% λμ λ° ν΅κ³Ό
1059095 to
78a4d27
Compare
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 3 out of 4 changed files in this pull request and generated no new comments.
Comments suppressed due to low confidence (2)
scanner/cli/appguardrail.py:64
- Avoid using a backslash line-continuation in an import; itβs fragile (whitespace-sensitive) and inconsistent with the surrounding parenthesized imports. Use a normal single-line import (or parentheses) instead.
from appguardrail_core.findings import \
is_deploy_blocking as core_is_deploy_blocking
scanner/cli/appguardrail.py:3074
- This header currently prints "Hint: Tips:", which is redundant and makes the output less clear. Prefer a single label (e.g., "Tips:") to keep the section header concise and consistent.
_console_print("π‘ Hint: Tips:")
π‘ What: CLI ν°λ―Έλ μΆλ ₯μμ μλ¬μ λμλ§ λ©μμ§μ μ λμ΄λ₯Ό λͺ ννκ² νμ€ννκ³ (
β Error:,π‘ Hint:), 리ν¬νΈ μλ μΆλ ₯ μ νλμ½λ©λ 볡μν λμ λ¨μ/볡μλ₯Ό λ¬Έλ§₯μ λ§κ² λμ μΌλ‘ νμνλλ‘ κ°μ νμ΅λλ€.π― Why:
1 componentsμ κ°μ μ΄μν λ¬Έλ²μ μ€λ₯λ₯Ό λ°©μ§νμ¬ κ°λ°μ λꡬλ‘μμ νμ§κ³Ό μ λ’°λλ₯Ό ν₯μμν€κΈ° μν¨μ λλ€.πΈ Before/After:
β Cannot start dashboard on 127.0.0.1:8787 (Address already in use).β Error: Cannot start dashboard on 127.0.0.1:8787 (Address already in use).π‘ Pass a free port with --port.π‘ Hint: Pass a free port with --port.π¦ SBOM (1 components) written: ...π¦ SBOM (1 component) written: ...βΏ Accessibility: μ€ν¬λ¦° 리λ μ¬μ©μλ₯Ό λΉλ‘―ν λͺ¨λ μ¬μ©μκ° 'μλ¬'μ 'ννΈ'λ₯Ό λͺ μμ μΈ ν μ€νΈ(
Error:,Hint:)λ₯Ό ν΅ν΄ μ΄λͺ¨μ§μ κ΄κ³μμ΄ λμΌνκ² μΈμν μ μλλ‘ μ 보 μ κ·Όμ±μ κ°μ νμ΅λλ€.PR created automatically by Jules for task 13316103699188961265 started by @seonghobae