Skip to content

🎨 Palette: Dashboard UI μ ‘κ·Όμ„± ν–₯상 (ν…Œμ΄λΈ” 및 λ‹€μ΄μ–Όλ‘œκ·Έ ARIA 속성 μΆ”κ°€)#331

Open
seonghobae wants to merge 1 commit into
developfrom
palette-accessibility-improvement-9769038650972165560
Open

🎨 Palette: Dashboard UI μ ‘κ·Όμ„± ν–₯상 (ν…Œμ΄λΈ” 및 λ‹€μ΄μ–Όλ‘œκ·Έ ARIA 속성 μΆ”κ°€)#331
seonghobae wants to merge 1 commit into
developfrom
palette-accessibility-improvement-9769038650972165560

Conversation

@seonghobae

Copy link
Copy Markdown
Contributor

πŸ’‘ What: Dashboard UI (scanner/dashboard/index.html)의 ν…Œμ΄λΈ” 및 Dialog μš”μ†Œμ— λŒ€ν•œ 접근성을 ν–₯μƒμ‹œν‚€λŠ” 마이크둜 UX κ°œμ„  사항을 μ μš©ν–ˆμŠ΅λ‹ˆλ‹€.

🎯 Why: ν‚€λ³΄λ“œ 및 슀크린 리더 μ‚¬μš©μžκ°€ μΈν„°λž™ν‹°λΈŒ ν…Œμ΄λΈ” 행을 μ‚¬μš©ν•  λ•Œ 이것이 λ‹€μ΄μ–Όλ‘œκ·Έ λͺ¨λ‹¬μ„ μ—¬λŠ” λ™μž‘μ„ ν•œλ‹€λŠ” 것을 λͺ…ν™•ν•˜κ²Œ μΈμ‹ν•˜κ³ , λ‹€μ΄μ–Όλ‘œκ·Έ λ‚΄ μš”μ†Œλ“€μ˜ λͺ…ν™•ν•œ 제λͺ©μ„ νŒŒμ•…ν•  수 μžˆλ„λ‘ 돕기 μœ„ν•¨μž…λ‹ˆλ‹€. <tr> μš”μ†Œμ™€ <dialog> μš”μ†Œκ°€ μ ‘κ·Όμ„± 지침을 더 잘 μ€€μˆ˜ν•˜λ„λ‘ λ§Œλ“­λ‹ˆλ‹€.

πŸ“Έ Before/After: μ‹œκ°μ  λ””μžμΈμ΄λ‚˜ λ ˆμ΄μ•„μ›ƒ λ³€κ²½ 사항은 μ—†μŠ΅λ‹ˆλ‹€ (μ‹œλ§¨ν‹± HTML 및 ARIA μ†μ„±λ§Œ λ³€κ²½). Playwright ν…ŒμŠ€νŠΈ μŠ€ν¬λ¦°μƒ·μœΌλ‘œ 확인 μ™„λ£Œν–ˆμŠ΅λ‹ˆλ‹€.

β™Ώ Accessibility:

  • <tr> 에 aria-haspopup="dialog" μΆ”κ°€.
  • <th> 에 scope="col" μΆ”κ°€.
  • <dialog> 및 ν•˜μœ„ <span class="t"> 에 aria-labelledby 와 id λ₯Ό ν†΅ν•œ λͺ…μ‹œμ  μ—°κ²° μΆ”κ°€.

PR created automatically by Jules for task 9769038650972165560 started by @seonghobae

- `index.html` 내에 슀크린 리더 접근성을 ν–₯μƒμ‹œν‚€λŠ” ARIA 및 Semantic 속성을 μΆ”κ°€ν–ˆμŠ΅λ‹ˆλ‹€.
- μΈν„°λž™ν‹°λΈŒν•œ ν–‰(`<tr>`)이 λ‹€μ΄μ–Όλ‘œκ·Έλ₯Ό μ—΄ 수 μžˆλ„λ‘ `aria-haspopup="dialog"` 속성을 μΆ”κ°€ν–ˆμŠ΅λ‹ˆλ‹€.
- ν…Œμ΄λΈ” 헀더(`<th>`) 셀이 열을 λ‚˜νƒ€λ‚΄λ„λ‘ `scope="col"` 속성을 μΆ”κ°€ν–ˆμŠ΅λ‹ˆλ‹€.
- λ„€μ΄ν‹°λΈŒ `<dialog>` μš”μ†Œκ°€ 동적 제λͺ©μ„ μ°Έμ‘°ν•  수 μžˆλ„λ‘ `aria-labelledby="dlg-title"` 및 `id="dlg-title"`을 μΆ”κ°€ν–ˆμŠ΅λ‹ˆλ‹€.
- `.Jules/palette.md` 에 μƒˆ UX ν•™μŠ΅ 일지 λ‚΄μš©μ„ κΈ°λ‘ν–ˆμŠ΅λ‹ˆλ‹€.
@google-labs-jules

Copy link
Copy Markdown

πŸ‘‹ Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a πŸ‘€ emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant