Skip to content

๐Ÿ›ก๏ธ Sentinel: [HIGH] Fix ๋ˆ„๋ฝ๋œ Slack/Webhook ์‹œํฌ๋ฆฟ ๋งˆ์Šคํ‚น ํ† ํฐ ์ถ”๊ฐ€ - #329

Closed
seonghobae wants to merge 3 commits into
developfrom
sentinel/fix-slack-webhook-redaction-16474462683798965785
Closed

๐Ÿ›ก๏ธ Sentinel: [HIGH] Fix ๋ˆ„๋ฝ๋œ Slack/Webhook ์‹œํฌ๋ฆฟ ๋งˆ์Šคํ‚น ํ† ํฐ ์ถ”๊ฐ€#329
seonghobae wants to merge 3 commits into
developfrom
sentinel/fix-slack-webhook-redaction-16474462683798965785

Conversation

@seonghobae

Copy link
Copy Markdown
Contributor

๐Ÿšจ Severity: HIGH
๐Ÿ’ก Vulnerability: scanner/rules/secrets.yml์— ์ถ”๊ฐ€๋œ hardcoded-slack-webhook-url ์‹œํฌ๋ฆฟ ๋ฃฐ์— ํ•ด๋‹นํ•˜๋Š” ํ† ํฐ(slack, webhook)์ด scanner/cli/appguardrail.py์˜ _SENSITIVE_RULE_TOKENS์— ๋ˆ„๋ฝ๋˜์–ด ์žˆ์—ˆ์Šต๋‹ˆ๋‹ค. ์ด๋กœ ์ธํ•ด CLI ์Šค์บ๋„ˆ ๊ฒฐ๊ณผ ์ถœ๋ ฅ์ด๋‚˜ CI/CD ๋กœ๊ทธ์— ์‹ค์ œ Slack Webhook URL์ด ๋งˆ์Šคํ‚น ์—†์ด ํ‰๋ฌธ์œผ๋กœ ๋…ธ์ถœ๋  ์œ„ํ—˜์ด ์กด์žฌํ–ˆ์Šต๋‹ˆ๋‹ค.
๐ŸŽฏ Impact: ๊ณต๊ฒฉ์ž๋‚˜ ์ธ๊ฐ€๋˜์ง€ ์•Š์€ ์ธ์›์ด CI ๋กœ๊ทธ๋‚˜ ํ„ฐ๋ฏธ๋„ ์ถœ๋ ฅ์— ๋…ธ์ถœ๋œ Slack Webhook URL์„ ํƒˆ์ทจํ•˜์—ฌ ํ•ด๋‹น ์›Œํฌ์ŠคํŽ˜์ด์Šค์— ์•…์˜์ ์ธ ๋ฉ”์‹œ์ง€๋‚˜ ํ”ผ์‹ฑ ๋งํฌ๋ฅผ ์ฃผ์ž…ํ•  ์ˆ˜ ์žˆ์Šต๋‹ˆ๋‹ค.
๐Ÿ”ง Fix: _SENSITIVE_RULE_TOKENS ํŠœํ”Œ์— "slack"๊ณผ "webhook"์„ ์ถ”๊ฐ€ํ•˜์—ฌ ํ•ด๋‹น ๋ฃฐ์— ๋งค์นญ๋˜๋Š” ์‹œํฌ๋ฆฟ ์Šค๋‹ˆํŽซ์ด ํ„ฐ๋ฏธ๋„ ํ™˜๊ฒฝ์—์„œ [REDACTED: sensitive match suppressed]๋กœ ์•ˆ์ „ํ•˜๊ฒŒ ๋งˆ์Šคํ‚น๋˜๋„๋ก ์ˆ˜์ •ํ–ˆ์Šต๋‹ˆ๋‹ค. ๋˜ํ•œ test_is_sensitive_rule_slack_webhook ํ…Œ์ŠคํŠธ ์ฝ”๋“œ๋ฅผ ์ถ”๊ฐ€ํ•˜์—ฌ ๊ฒ€์ฆ์„ ๊ฐ•ํ™”ํ–ˆ์Šต๋‹ˆ๋‹ค.
โœ… Verification: python -m pytest tests/ ๋ช…๋ น์–ด๋กœ ์ถ”๊ฐ€๋œ ํ…Œ์ŠคํŠธ ์ผ€์ด์Šค์™€ ์ „์ฒด ํ…Œ์ŠคํŠธ ์ŠˆํŠธ๊ฐ€ 100% ์ •์ƒ ํ†ต๊ณผํ•จ์„ ํ™•์ธํ–ˆ์Šต๋‹ˆ๋‹ค.


PR created automatically by Jules for task 16474462683798965785 started by @seonghobae

@google-labs-jules

Copy link
Copy Markdown

๐Ÿ‘‹ Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a ๐Ÿ‘€ emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

Copilot AI review requested due to automatic review settings July 23, 2026 01:53

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR hardens AppGuardrailโ€™s CLI output redaction so findings for the new hardcoded-slack-webhook-url secret rule wonโ€™t leak real Slack webhook URLs into terminal output or CI logs.

Changes:

  • Add "slack" and "webhook" to scanner/cli/appguardrail.pyโ€™s _SENSITIVE_RULE_TOKENS so matching findings have their snippets suppressed.
  • Add a unit test asserting Slack rule IDs are treated as sensitive.
  • Document the incident/learning in .jules/sentinel.md.

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.

File Description
scanner/cli/appguardrail.py Expands sensitive rule token list to ensure Slack webhook findings are snippet-redacted.
tests/test_appguardrail.py Adds a regression test for _is_sensitive_rule() covering Slack webhook/token rule IDs.
.jules/sentinel.md Records the missing-redaction-token issue and the preventative practice going forward.

Comment thread tests/test_appguardrail.py
Copilot AI review requested due to automatic review settings July 23, 2026 02:05
@seonghobae
seonghobae enabled auto-merge (squash) July 23, 2026 02:05

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 3 out of 3 changed files in this pull request and generated 3 comments.

Comment thread scanner/cli/appguardrail.py
Comment thread tests/test_appguardrail.py
Comment thread .jules/sentinel.md
@opencode-agent
opencode-agent Bot disabled auto-merge July 23, 2026 03:44
@seonghobae

Copy link
Copy Markdown
Contributor Author

Closing as no-path: merge conflicts with develop (DIRTY/CONFLICTING). Duplicate bot work already covered by newer open PRs (e.g. SSRF via #426 auto-merge, palette/bolt successors). Reopen only from a rebased branch with unique delta.

@seonghobae seonghobae closed this Jul 31, 2026
@github-project-automation github-project-automation Bot moved this from Backlog to Done in Security Jul 31, 2026
@google-labs-jules

Copy link
Copy Markdown

Closing as no-path: merge conflicts with develop (DIRTY/CONFLICTING). Duplicate bot work already covered by newer open PRs (e.g. SSRF via #426 auto-merge, palette/bolt successors). Reopen only from a rebased branch with unique delta.

Understood. Acknowledging that this work is obsolete due to merge conflicts and duplicate efforts. Stopping work on this task.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

2 participants