docs(examples): align READMEs with 1.0.0; fix car-sharing chain order#25
Conversation
- car-sharing: interceptor order to ADR-024 (auth immediately after errorHandler, before validation; OTel after authz for enduser span attributes) -- e2e 7/7, typecheck clean - car-sharing Dockerfile builds without a committed lockfile (pnpm install resolves @connectum/* to published 1.0.0) - README fixes: extensions/redact proto note, getting-started Node floor, with-events-dlq metadata, missing deps; rateLimit comment (fixed-window) Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01MdeH7fExPmiRHRirGuvGk3
|
Warning Review limit reached
More reviews will be available in 59 minutes and 59 seconds. Learn how PR review limits work. Your organization has used up its prepaid credits, and credit purchases are no longer available. Enable the review add-on in the billing tab to keep reviews running — you're only billed for reviews past your plan's rate limits ($0.25/file). ⌛ How to resolve this issue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based credits. 🚦 How do rate limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan refill rate. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, the refill rate gradually slows as usage increases. The highest same-day bursts are limited more strictly. Please see our Fair Usage Limits Policy for further information. ℹ️ Review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (13)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
@coderabbitai review |
✅ Action performedReview finished.
|
1 participant
Summary
Example READMEs aligned with the published 1.0.0 surface, plus one verified code
fix in the
car-sharingflagship.car-sharing interceptor order (ADR-024)
The gateway chain placed authentication after validation/observability. It now
follows ADR-024 —
errorHandler → JWT auth → proto authz → OTel → validation—so unauthenticated requests are rejected before validation, and OTel runs after
authz so
getAuthContext()is populated forenduser.*span attributes.Verified:
tsc --noEmitclean, e2e 7/7 pass.The
car-sharingDockerfile now builds without a committed lockfile (pnpm installresolves@connectum/*to the published 1.0.0 versions), matching theexample's no-committed-lockfile policy.
README fixes
extensions/redact: the illustrative proto block is marked as hand-rolledstubs (no
connectum/options.protoexists).getting-started: Node floor consistency (>=25.2.0for run-directly TS).with-events-dlq: DLQ metadata description and theerrorSerializernote.extensions/redactandinterceptors/jwt;hrislayout;
with-custom-interceptordoc comment (fixed-window).Part of a coordinated 1.0.0 documentation pass with companion PRs in the
framework and docs repositories.
🤖 Generated with Claude Code
https://claude.ai/code/session_01MdeH7fExPmiRHRirGuvGk3