Skip to content

docs: fix audited contradictions, stale API; add documentation style guide#47

Merged
intech merged 3 commits into
mainfrom
docs/audit-fixes-1.0.0
Jun 20, 2026
Merged

docs: fix audited contradictions, stale API; add documentation style guide#47
intech merged 3 commits into
mainfrom
docs/audit-fixes-1.0.0

Conversation

@intech

@intech intech commented Jun 20, 2026

Copy link
Copy Markdown
Contributor

Summary

Documentation-site fixes from a full audit against the published 1.0.0 surface
(oracle = @connectum/* source, not prose or fixtures), plus a new style guide
and a simpler top navigation.

Contradictions & stale API fixed

  • Interceptor chain order (ADR-024). The homepage hero and the auth guides
    placed authentication outside errorHandler. They now follow the documented
    order — errorHandler → auth → authz → otel → validation — and the chain
    diagrams agree with the code samples.
  • Generated-code imports. The #gen/* convention is documented accurately
    (extension follows buf.gen.yaml; run-directly projects use .ts), fixing the
    quickstart self-contradiction and the "always .js" claim.
  • about.md "Resilience by Default" → opt-in resilience; auth header encoding
    (roles JSON / scopes space-separated); propagatedClaims moved off the JWT
    interceptor; transportParityTest imported from @connectum/testing/parity;
    router.rpc v2 signature; otel package layer; DlqOptions.errorSerializer
    return type.
  • Contributing reference: Buf instead of standalone protoc, the >=22.13.0
    consumer floor, and a dist-based new-package scaffold.

Additions

  • New Documentation Style Guide
    the canonical template for package READMEs and site pages.
  • Top nav simplified: a Resources dropdown surfaces Migration & Changelog,
    Contributing, and Examples.
  • ADR-024 note on OTel interceptor placement; architecture.md de-duplicated
    against the service-communication patterns page.

The site builds cleanly (no dead links). Part of a coordinated 1.0.0 docs pass
with companion PRs in the framework and examples repositories.

🤖 Generated with Claude Code

https://claude.ai/code/session_01MdeH7fExPmiRHRirGuvGk3

…le guide

Source-verified across the site (oracle = published 1.0.0):
- interceptor chain order per ADR-024 on the homepage and auth guides
  (errorHandler -> auth -> authz -> otel -> validation)
- generated #gen import convention (.ts), about.md opt-in resilience
- auth header encoding, propagatedClaims, transportParityTest /parity import,
  router.rpc v2 signature, otel package layer, DlqOptions return type
- contributing: Buf (not protoc), Node >=22.13.0 floor, dist-based scaffold
- new contributing/documentation-style.md; nav Resources dropdown surfaces
  Migration; ADR-024 OTel placement note; architecture.md de-duplicated

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01MdeH7fExPmiRHRirGuvGk3
@github-actions github-actions Bot added the type:docs Documentation: guides, README, JSDoc label Jun 20, 2026
intech and others added 2 commits June 20, 2026 14:28
…s out

- Guide sidebar regrouped from 16 flat groups into 6 phases: Introduction,
  Build a Service, Connect Services, Secure, Operate, Deploy
- the 15 package pages move to their own Packages nav section, grouped by layer
- Architecture Overview and the floating single pages (Validation, Runtime
  Compatibility) placed in logical phases; no page URLs change

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01MdeH7fExPmiRHRirGuvGk3
…rule

Aligns the footer guidance with the existing READMEs, which use either the
ASCII '--' em-dash (the prose convention, 9 packages) or a real em-dash; avoids
a guideline that contradicts the shipped footers.

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01MdeH7fExPmiRHRirGuvGk3
@intech intech merged commit eef4caa into main Jun 20, 2026
3 checks passed
@intech intech deleted the docs/audit-fixes-1.0.0 branch June 20, 2026 12:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

type:docs Documentation: guides, README, JSDoc

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant