Skip to content

fix: mark dsn as isSecret in config_schema#39

Open
btipling wants to merge 1 commit into
mainfrom
bt/secret-audit-sql-server
Open

fix: mark dsn as isSecret in config_schema#39
btipling wants to merge 1 commit into
mainfrom
bt/secret-audit-sql-server

Conversation

@btipling

Copy link
Copy Markdown
Contributor

Marks the dsn field as a secret credential. The SQL Server connection string embeds authentication material (typically user id/password), so it must be treated as a secret; it was not flagged isSecret.

This connector defines its config in cmd/baton-sql-server/config.go and does not commit a root config_schema.json; the schema is generated from these field definitions, so adding field.WithIsSecret(true) is the equivalent fix (no committed config_schema.json to regenerate).

BREAKING: adding isSecret: true to these fields changes how existing configurations are stored. Customers with existing connector configurations will need to re-enter credentials after this change is deployed.

Audit: connector-secret-audit-phase15. Do not merge without review.

@btipling btipling requested a review from a team June 13, 2026 03:02
@github-actions

Copy link
Copy Markdown
Contributor

Connector PR Review: fix: mark dsn as isSecret in config_schema

Blocking Issues: 0 | Suggestions: 0 | Threads Resolved: 0
Review mode: full
View review run

Review Summary

Single-line change adds field.WithIsSecret(true) to the dsn config field in cmd/baton-sql-server/config.go. The SQL Server connection string embeds authentication material (user/password), so marking it as a secret is the correct fix. The change is well-scoped and the breaking-change note in the PR description is appropriate.

Security Issues

None found.

Correctness Issues

None found.

Suggestions

None.

@github-actions github-actions Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No blocking issues found.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant