fix: mark dsn as isSecret in config_schema#39
Open
btipling wants to merge 1 commit into
Open
Conversation
Contributor
Connector PR Review: fix: mark dsn as isSecret in config_schemaBlocking Issues: 0 | Suggestions: 0 | Threads Resolved: 0 Review SummarySingle-line change adds Security IssuesNone found. Correctness IssuesNone found. SuggestionsNone. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Marks the
dsnfield as a secret credential. The SQL Server connection string embeds authentication material (typicallyuser id/password), so it must be treated as a secret; it was not flaggedisSecret.This connector defines its config in
cmd/baton-sql-server/config.goand does not commit a rootconfig_schema.json; the schema is generated from these field definitions, so addingfield.WithIsSecret(true)is the equivalent fix (no committedconfig_schema.jsonto regenerate).Audit: connector-secret-audit-phase15. Do not merge without review.