fix: mark dsn as isSecret in config schema#48
Open
btipling wants to merge 1 commit into
Open
Conversation
Contributor
Connector PR Review: fix: mark dsn as isSecret in config schemaBlocking Issues: 0 | Suggestions: 0 | Threads Resolved: 0 Review SummarySingle-line change adds Security IssuesNone found. Correctness IssuesNone found. SuggestionsNone. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Marks credential field(s)
dsn(the DSN connection string embeds the database password) as secret in this connector's config so the credential is stored and handled as a secret rather than plaintext.This connector defines its config in Go (
fieldpackage), not aconfig.yaml. Secret-ness is thefield.WithIsSecret(true)option on the field — the authoritative source. There is no committedconfig_schema.jsonin this repo, and the generatedconf.gen.gois a mapstructure struct that carries no secret metadata, so the one-lineconfig.gochange is the complete fix and a CI regen produces no additional diff (no race).BREAKING
Audit
Part of the connector config secret-ness audit (phase 13). Found via systematic review of credential fields lacking
isSecret.Do not merge — left open for review.