Add GrantReplaced annotation for grant

[MarcusGoldschmidt]

No description provided.

[github-actions]

Connector PR Review: Add GrantReplaced annotation for grant

Blocking Issues: 0 | Suggestions: 1 | Threads Resolved: 0
Review mode: incremental since 9ef5db4
View review run

Review Summary

The new commits extract the "read" string literal into a readConst constant and replace three occurrences across roleNameToRepoPermission, getOrgBasePermission, and orgBasePermissionToRepoPermissions. The core GrantReplaced annotation logic from the prior commits is unchanged and looks correct—collaborator check, permission-level lookup, idempotent GrantAlreadyExists handling, and replaced-grant ID construction all follow SDK conventions. One minor naming suggestion on the new constant.

Security Issues

None found.

Correctness Issues

None found.

Suggestions

• readConst naming in pkg/connector/repository.go:34 — name encodes Go type rather than domain concept; consider apiRoleRead for clarity.

Prompt for AI agents

Verify each finding against the current code and only fix it if needed.

## Suggestions

In `pkg/connector/repository.go`:
- Around line 34: Rename `readConst` to something like `apiRoleRead` or `roleNameRead` to
  distinguish the GitHub API role vocabulary ("read"/"write") from the entitlement permission
  vocabulary ("pull"/"push"). Update all references (lines 51, 82, 85) accordingly.

[github-actions]

No blocking issues found.

[github-actions]

🟡 Suggestion: readConst encodes the Go type in the name rather than describing the domain concept. The other constants in this file use the repoPermission* prefix. Consider a name like apiRoleRead or roleNameRead to clarify this is the GitHub API's role vocabulary (as opposed to the entitlement permission vocabulary).

Suggested change

	const readConst = "read"
	const apiRoleRead = "read"

[github-actions]

No blocking issues found.