Skip to content

chore(deps): bump nextcloud-vue to beta.220 (OpenBuild glyph fix) - #384

Closed
rubenvdlinde wants to merge 1 commit into
developmentfrom
chore/ncvue-beta220-glyph
Closed

chore(deps): bump nextcloud-vue to beta.220 (OpenBuild glyph fix)#384
rubenvdlinde wants to merge 1 commit into
developmentfrom
chore/ncvue-beta220-glyph

Conversation

@rubenvdlinde

Copy link
Copy Markdown
Contributor

Bumps @conduction/nextcloud-vue to ^1.0.0-beta.220, picking up the OpenBuild edit-button glyph fix (package/cube → OpenBuild stacked-layers icon), shipped in beta.218.

This app's currently-shipped bundle binds the old cube glyph (confirmed by scanning the built js/ for the path bound to cn-openbuild-edit__glyph), so it needs this bump for its next CI/release build to ship the correct icon.

Dependency-only change — no source edits.

Picks up the OpenBuild edit-button glyph fix (package/cube -> OpenBuild
stacked-layers), shipped in beta.218. This app's bundle still binds the old
cube glyph, so its next CI/release build needs this bump.
@rubenvdlinde

Copy link
Copy Markdown
Contributor Author

Closing in favour of #412.

This PR bumps @conduction/nextcloud-vue from 1.0.0-beta.213 to 1.0.0-beta.220. That is the Vue 2 line. #412 migrates shillinq to Vue 3 and pins 2.1.0-vue3.16 exactly, so merging this afterwards would move the dependency backwards onto a release line that cannot work against Vue 3.5 / @nextcloud/vue@9.

The branch is also already CONFLICTING against development.

If the OpenBuild glyph fix is still missing on the Vue 3 line, it should be re-landed as a fix against 2.1.0-vue3.x rather than by merging this branch. The branch is left intact (not deleted) so the original change stays recoverable.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant