fix(l10n): register the grant-write error string added in #135 - #137
Merged
Conversation
`l10n coverage (en.json)` has been RED on development since #135. The string `"The agent was saved, but its tool grants were not updated…"` was added to AgentFormModal without its `l10n/en.json` entry, and l10n is a separate workflow from Code Quality — so watching the 31-job quality run go green said nothing about it. Exactly the failure this fleet keeps re-learning: a gate you are not looking at is a gate that is not there. It also blocked an unrelated dependabot PR (#27), which rebased onto a development that was already red and inherited the failure. Adds the English key (via `check-l10n.js --write`) and a Dutch translation (ADR-005/ADR-007 — user-facing strings ship in both). `check-l10n.js` now reports OK.
rubenvdlinde
requested review from
Rem-Dam,
SudoThijn,
WilcoLouwerse,
bbrands02,
remko48 and
rjzondervan
as code owners
August 4, 2026 01:22
Contributor
Quality Report — ConductionNL/hermiq @
|
| Check | PHP | Vue | Security | License | Tests |
|---|---|---|---|---|---|
| lint | ✅ | ||||
| phpcs | ✅ | ||||
| phpmd | ✅ | ||||
| psalm | ✅ | ||||
| phpstan | ✅ | ||||
| phpmetrics | ✅ | ||||
| eslint | ✅ | ||||
| stylelint | ✅ | ||||
| build | ✅ | ||||
| composer | ✅ | ✅ 117/117 | |||
| npm | ✅ | ✅ 744/744 | |||
| PHPUnit | ✅ | ||||
| Newman | ✅ | ||||
| Playwright | ✅ |
Quality workflow — 2026-08-04 01:28 UTC
Download the full PDF report from the workflow artifacts.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
l10n coverage (en.json)has been red on development since #135 — my change.The string
"The agent was saved, but its tool grants were not updated…"was added toAgentFormModal.vuewithout itsl10n/en.jsonentry. l10n runs as a separate workflow from Code Quality, so watching the 31-job quality run go green said nothing about it.That is the failure this fleet keeps re-learning in a new costume: a gate you are not looking at is a gate that is not there. I checked the workflow I had just fixed and not the one beside it.
It also blocked an unrelated dependabot PR (#27), which rebased onto a development that was already red and inherited the failure — so this was quietly costing other work too.
Changes
node tests/l10n/check-l10n.js --write).--writeonly fills the English side.Verification
node tests/l10n/check-l10n.js→OK — every used translation key is present in l10n/en.json(1018 used / 1124 present). All three l10n files parse as valid JSON.🤖 Generated with Claude Code