Add support for armv7l#404
Open
lgmu wants to merge 2 commits into
Open
Conversation
sni
reviewed
Jul 8, 2026
| ifeq ($(GOARCH),aarch64) | ||
| export GOARCH := arm64 | ||
| endif | ||
| ifeq ($(GOARCH),armv7l) |
Contributor
There was a problem hiding this comment.
first you set GOARCH to arm and because of that, you need to set it back later by NODE_EXPORTER_ARCH. This doesn't make sense to me. Why not keep GOARCH as it is.
The only variable different from GOARCH is DEB_ARCH.
| ifeq ($(DEB_ARCH),386) | ||
| DEB_ARCH := i386 | ||
| endif | ||
| ifeq ($(DEB_ARCH),arm) |
Contributor
There was a problem hiding this comment.
simply check for armv7l here, then you don't have to copy multiple variables back and forth.
|
|
||
| NODE_EXPORTER_VERSION=1.11.1 | ||
| NODE_EXPORTER_FILE=node_exporter-$(NODE_EXPORTER_VERSION).$(GOOS)-$(GOARCH).tar.gz | ||
| NODE_EXPORTER_FILE=node_exporter-$(NODE_EXPORTER_VERSION).$(GOOS)-$(NODE_EXPORTER_ARCH).tar.gz |
Contributor
There was a problem hiding this comment.
all this changes are not required.
| 4df4ec0dca5bc061c59181cfedcd8887cb5df9c710db3c4038bc51923414bc5d node_exporter-1.11.1.linux-386.tar.gz | ||
| 9f5ea48e5bc7b656f8a91a32e7d7deb89f70f73dabd0d974418aca15f37d6810 node_exporter-1.11.1.linux-amd64.tar.gz | ||
| ba1886efbd76cb96b0087c695ea8d1b9cb6e8aa946c996d744e9ee16c8e3591a node_exporter-1.11.1.linux-arm64.tar.gz | ||
| 661c662e566d5c68950d63f7dfd1ec46ba28858f91aeba220c32baa1d3ad7b33 node_exporter-1.11.1.linux-armv7.tar.gz |
Contributor
There was a problem hiding this comment.
have you changed this file manually? Because it is auto-generated by make updatenodeexportersums
This make target should be adjusted as well.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Tested the binary itself + installing the .deb package (node_exporter works aswell)