Repository navigation
Fix/fatal log terminal state - #758
Merged
Merged
Conversation
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
frjcomp
force-pushed
the
fix/fatal-log-terminal-state
branch
from
October 20, 2026 11:51
e75416e to
e5dca76
Compare
Contributor
There was a problem hiding this comment.
🔵 Needs a closer look
Unresolved correctness issues and security-sensitive download, archive, and process-exit changes require fixes, runtime validation, and human review.
No open issues 🎉
What changed in this PR
Adds GitLab release-asset secret scanning and moves terminal restoration after fatal-log output.
Changes:
- Adds release discovery, asset downloads, and bounded archive scanning.
- Adds configuration documentation and unit/end-to-end coverage.
- Updates fatal-log writers and adds GitHub CLI to the dev container.
| File | Description |
|---|---|
| tests/e2e/gitlab/release/scan_test.go | Tests release-scanning workflows. |
| pkg/scan/artifact/release.go | Processes release files and nested archives. |
| pkg/scan/artifact/release_test.go | Tests archive processing and limits. |
| pkg/gitlab/release/scan/scanner.go | Discovers releases and coordinates scanning. |
| pkg/gitlab/release/scan/scanner_test.go | Tests discovery and filtering. |
| pkg/gitlab/release/scan/download.go | Downloads assets with credential isolation. |
| pkg/gitlab/release/scan/download_test.go | Tests downloads, redirects, and limits. |
| pkg/docs/release_test.go | Tests generated command documentation. |
| pkg/config/gen/release_test.go | Tests generated release configuration. |
| internal/cmd/root.go | Restores terminal after fatal output. |
| internal/cmd/root_test.go | Tests fatal-write ordering. |
| internal/cmd/gitlab/release/scan/scan.go | Defines command flags and configuration. |
| internal/cmd/gitlab/release/scan/scan_test.go | Tests command configuration and precedence. |
| internal/cmd/gitlab/release/release.go | Adds release command group. |
| internal/cmd/gitlab/release/release_test.go | Tests command registration. |
| internal/cmd/gitlab/gitlab.go | Registers release commands. |
| internal/cmd/gitlab/gitlab_test.go | Checks release command discovery. |
| internal/cmd/common/common.go | Updates shared fatal-log handling. |
| internal/cmd/common/common_test.go | Tests shared fatal-write ordering. |
| docs/introduction/configuration.md | Documents release configuration. |
| docs/guides/gitlab.md | Explains release scanning and limitations. |
| cmd/pipeleek/main.go | Removes obsolete terminal-restoring writer. |
| .devcontainer/devcontainer.json | Adds GitHub CLI tooling. |
Review effort: Balanced
Initialize keyboard raw mode synchronously and serialize terminal startup and cleanup. Restore input on normal, error, fatal, and graceful shutdown paths without parsing fatal log entries. Add pseudo-terminal regression tests and preserve keyboard shortcuts and newline processing. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #755