Chore/k6 updates - #1610
Open
Odonno wants to merge 3 commits into
Open
Chore/k6 updates#1610Odonno wants to merge 3 commits into
Odonno wants to merge 3 commits into
Conversation
Contributor
|
🚀 Dogfood this PR with:
curl -fsSL https://raw.githubusercontent.com/CommunityToolkit/Aspire/main/eng/scripts/dogfood-pr.sh | bash -s -- 1610Or
iex "& { $(irm https://raw.githubusercontent.com/CommunityToolkit/Aspire/main/eng/scripts/dogfood-pr.ps1) } 1610" |
afscrome
requested changes
Sep 22, 2026
|
|
||
| [AspireExport] | ||
| public static ApplicationModel.IResourceBuilder<ApplicationModel.K6Resource> WithScript(this ApplicationModel.IResourceBuilder<ApplicationModel.K6Resource> builder, string scriptPath, int virtualUsers = 10, string duration = "30s") { throw null; } | ||
| public static ApplicationModel.IResourceBuilder<ApplicationModel.K6Resource> WithScript(this ApplicationModel.IResourceBuilder<ApplicationModel.K6Resource> builder, string scriptPath, int? virtualUsers = null, string? duration = null) { throw null; } |
Contributor
There was a problem hiding this comment.
This doesn't match the API definition below - it's missing the K6SummaryMode option.
afscrome
requested changes
Sep 22, 2026
| string duration = "30s") | ||
| int? virtualUsers = null, | ||
| string? duration = null, | ||
| K6SummaryMode? summaryMode = null) |
Contributor
There was a problem hiding this comment.
Adding an additional parameter & changing types (int --> int?) is a breaking API change.
Not entirely sure on this repo's approach to breaking changes, but I suggest adding a new overload, rather than changing the existing signature.
Contributor
|
I've also caused a conflict with renaming |
Odonno
force-pushed
the
chore/k6-updates
branch
from
September 23, 2026 06:55
ae12cc9 to
33a68b0
Compare
Odonno
force-pushed
the
chore/k6-updates
branch
from
September 23, 2026 06:57
33a68b0 to
7ca1687
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1604
nullto avoid environment override2.3.0(no major changes needed)summary-modevariable to be passed during script executionPR Checklist
Other information
Since args now defaults to
null, it can be considered a breaking change.