Repository navigation
Quips for commands aimed at the bot itself - #5
Open
devin-ai-integration[bot] wants to merge 1 commit into
Open
devin-ai-integration[bot] wants to merge 1 commit into
devin-ai-integration[bot] wants to merge 1 commit into
Conversation
Proposals sent to the bot (marry/adopt/makeparent) could never be accepted - the bot can't click its own buttons - so they now get a random decline quip instead of a dangling proposal. Fun commands (hug, pat, poke, ...) aimed at the bot fire back a line, and block and relationship get their own replies for bot targets too. Co-Authored-By: Devin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com>
Contributor
Author
|
I'll fix CI failures and address comments from users with write access. I'll skip comments containing "(aside)".
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Commands aimed at Matrimony's own account now get quips instead of dead ends, in the same style as the existing self-target replies ("You can't marry yourself, as much as you may want to.").
_send_proposalinterceptsmarry/adopt/makeparentwhen the target is the bot itself and replies with a random line from_SELF_PROPOSAL_QUIPS— previously these created proposals the bot could never accept, so they just sat until expiry.hug,pat,poke,stab, ...) answer"<author> <verb> me. <quip> <emoji>"with a random line from_SELF_FUN_QUIPSwhen booping the bot, while still fetching the action GIF.blockon the bot replies "You can't block me. I'm already family." andrelationshipinvolving the bot replies "Me? I'm honorary family to everyone." when unrelated._is_me(bot, user)helper; other-bot proposals are unaffected (they still go through the normal proposal flow).tests/test_dispatch.pygains 8 tests covering the quips plus the unchanged other-bot/other-user paths.Example replies:
Link to Devin session: https://app.devin.ai/sessions/638d22e91c404258abafe65097954722
Open in Devin Desktop: https://app.devin.ai/desktop/session/638d22e91c404258abafe65097954722?variant=devin
Requested by: @CommunityPoke