Unify projects and issues lifecycle UX (AXI-108)#40
Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: dbf85a52b9
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| view: next.view !== undefined ? next.view : (activeViewId ?? viewIdFromUrl), | ||
| dueOn: next.dueOn !== undefined ? next.dueOn : dueOn, | ||
| archived: next.archived ?? showArchived, | ||
| scope: next.scope ?? scope, |
There was a problem hiding this comment.
Avoid persisting derived All scope
When a DONE/CANCELED status facet is active, scope is derived as "all" even if the URL never requested scope=all; any later filter change that does not pass next.scope uses this fallback and writes scope=all into the URL. For example, selecting a Done status and then toggling that same facet off removes the terminal filter but leaves the page in All scope, so completed issues continue to appear until the user manually clears filters or presses Open. Recompute the fallback from the next filters/requested URL scope instead of persisting the derived value.
Useful? React with 👍 / 👎.
Summary
Why
Completed issues could appear or disappear solely from switching between List and Kanban, while the UI did not clearly communicate whether terminal work was included. Project creation also deferred required-field guidance until submission, did not explain the immutable key, retained stale validation feedback, and returned users to the grid after creation.
User impact
Issue search and filtering now have a visible, predictable lifecycle baseline. Users can recover completed search results directly, presentation changes no longer alter the result universe, and new-project setup provides clearer guidance and a more direct continuation flow.
Validation
pnpm typecheckpnpm lint(passes with existing repository warnings)pnpm exec vitest run tests/unit/saved-view-filters.test.ts— 13 passedpnpm exec playwright test tests/e2e/issues-scope.spec.ts --workers=1— 2 passedgit diff --checkThe unconfigured full
pnpm testintegration run could not connect because this shell did not provideDATABASE_URLorAUTH_SECRET; the focused dependency-free suite and isolated production browser flows passed.